[Laszlo-dev] For Review: Change 20080324-dda-f Summary: doc: Add charts and some minor cleanups in HTML/Media category
Donald Anderson
dda at ddanderson.com
Thu Mar 27 06:36:03 PDT 2008
I'll see what I can do to clean this up.
Since this has been advertised as 'beta quality', if I need to
change a public attribute or method name to clean it up, can I do that?
Obviously, if I can fix warnings without public API changes, I will do
that.
I'll add the disclaimer again and fit the examples.
On Mar 27, 2008, at 9:10 AM, P T Withington wrote:
> That's a basic flaw in the design. You can't have an attribute and
> a method with the same name. So, this couldn't have worked in the
> past, but now at least you are being told about it at compile time.
> I don't know enough about the charts package to be authoritative,
> but it seems to me that rather than piepiece inheriting from
> drawview, perhaps it just needs a drawview property to do its
> drawing on. Alternatively, change the name of the property in
> piepiece to not conflict.
>
> On 2008-03-27, at 07:48 EDT, Lou Iorio wrote:
>> Don,
>>
>> Yes, the example work now. However, now I'm getting compiler
>> errors, for example, for barchart:
>>
>> charts/piechart/piepiece.lzx:5:47: In class 'piepiece' attribute
>> 'arc' with type 'number' is overriding superclass attribute with
>> same name but different type: method
>> charts/piechart/piepiece.lzx:16:57: In element 'class' attribute
>> 'arc' with type 'number' is overriding parent class attribute with
>> same name but different type: method
>> charts/piechart/piepiece.lzx:16:57: In element 'class' attribute
>> 'arc' is overriding parent class attribute which has the same name
>> but type: method
>>
>> In addition, the code in the example needs to be ex-dented so it
>> fits on the page.
>>
>> All the pages for Chart should have the disclaimer from 3.4:
>>
>> This component is of Beta quality and is subject to change.
>>
>> On Mar 26, 2008, at 8:12 PM, Donald Anderson wrote:
>>
>>> Lou,
>>>
>>> Looks like Tucker's latest changes in trunk have fixed this.
>>> If you do an svn update and do an 'ant clean build' at the top of
>>> your
>>> tree, as well as 'cd docs/src; ant reference', you should get
>>> a doc set that has working examples.
>>>
>>> - Don
>>>
>>> On Mar 24, 2008, at 8:35 PM, Lou Iorio wrote:
>>>
>>>> When I open a page with example code, like barchart, I get a
>>>> compile error. If I go to the OpenLaszlo Editor, I get this:
>>>>
>>>> Compilation Errors
>>>> extensions/drawview.lzx:18:5: Syntax error: the token "extends"
>>>> was not expected at this position.
>>>> Compilation Warnings
>>>> charts/piechart/piepiece.lzx:5:47: In class 'piepiece' attribute
>>>> 'arc' with type 'number' is overriding superclass attribute with
>>>> same name but different type: method
>>>>
>>>> I did a svn update, then a complete build: ant clean build doc
>>>>
>>>> Lou
>>>>
>>>> On Mar 24, 2008, at 6:24 PM, Donald Anderson wrote:
>>>>> Change 20080324-dda-f by dda at lester.local on 2008-03-24 17:45:39
>>>>> EDT
>>>>> in /Users/dda/laszlo/src/svn/openlaszlo/trunk-doc2
>>>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>>>
>>>>> Summary: doc: Add charts and some minor cleanups in HTML/Media
>>>>> category
>>>>>
>>>>> New Features:
>>>>>
>>>>> Bugs Fixed: LPP-4935 (complete), LPP-5396 (partial)
>>>>>
>>>>> Technical Reviewer: (pending)
>>>>> QA Reviewer: (pending)
>>>>> Doc Reviewer: liorio (pending)
>>>>>
>>>>> Documentation:
>>>>> See details.
>>>>>
>>>>> Release Notes:
>>>>>
>>>>> Details:
>>>>> - To Contents tab under HTML, replaced LzTextFormat
>>>>> (deprecated) by textformat.
>>>>> - To Contents tab under Charts, copied list from 3.4.
>>>>> - Insert @access public judiciously in charts sources.
>>>>> - In charts sources, worked around a couple problems where
>>>>> <include>
>>>>> was not always working to pick up contents of needed files.
>>>>> This was done by inserting a couple of redundant <include>
>>>>> tags
>>>>> to pick up the needed files. The two problems:
>>>>> -- <include href="../xxx/file.lzx"> is silently failing to
>>>>> open the file.
>>>>> I made some primitive attempts to fix in the xsl before
>>>>> deciding to workaround.
>>>>> -- <include href="piechartplotarea.lzx"> is failing to get
>>>>> included content when used from piechart.lzx.
>>>>> Did some prelim diagnosis, but still do not know the
>>>>> reason.
>>>>> - Also corrected an errant include of legend.lzx in
>>>>> piechart.lzx (it was probably
>>>>> already included elsewhere, allowing it to work).
>>>>> - Changed the file headers for LzAudio.lzs and LzFont.lzs
>>>>> files to be @access public
>>>>> in an attempt to produce content for these files.
>>>>> LzFont.html is now produced,
>>>>> and is referenced from TOC.
>>>>> - fixed a couple typos in content.
>>>>>
>>>>> Tests:
>>>>> Testing content:
>>>>> Did 'ant reference' in docs/src and checked all the links in
>>>>> the changed sections of the TOC.
>>>>> Testing charts:
>>>>> Did 'ant clean; ant; at the top of the tree to rebuild
>>>>> everything (especially charts).
>>>>> Checked that the doc chart examples run.
>>>>> Regression:
>>>>> did smokecheck SWF8/DHTML
>>>>>
>>>>> Files:
>>>>> M WEB-INF/lps/lfc/kernel/swf/LzAudio.as
>>>>> M WEB-INF/lps/lfc/helpers/LzFont.lzs
>>>>> M docs/src/nav/toc.xml
>>>>> M docs/src/reference/wrappers.xml
>>>>> M docs/src/xsl/lzx2js2doc.xsl
>>>>> M lps/components/charts/columnchart/columnchart.lzx
>>>>> M lps/components/charts/piechart/piechartplotarea.lzx
>>>>> M lps/components/charts/piechart/piechart.lzx
>>>>> M lps/components/charts/library.lzx
>>>>> M lps/components/charts/styles/chartstyle.lzx
>>>>> M lps/components/charts/addon/library.lzx
>>>>> M lps/components/charts/addon/zoomarea.lzx
>>>>> M lps/components/charts/barchart/barchart.lzx
>>>>> M lps/components/charts/common/axis.lzx
>>>>> M lps/components/charts/common/library.lzx
>>>>> M lps/components/charts/common/datalabel.lzx
>>>>> M lps/components/charts/common/valuepoints.lzx
>>>>> M lps/components/charts/common/datamarker.lzx
>>>>> M lps/components/charts/common/horizontalaxis.lzx
>>>>> M lps/components/charts/common/label.lzx
>>>>> M lps/components/charts/common/valueregion.lzx
>>>>> M lps/components/charts/common/dataseries.lzx
>>>>> M lps/components/charts/common/valueline.lzx
>>>>> M lps/components/charts/common/datatip.lzx
>>>>> M lps/components/charts/common/rectangularchart.lzx
>>>>> M lps/components/charts/common/legend.lzx
>>>>> M lps/components/charts/common/verticalaxis.lzx
>>>>> M lps/components/charts/common/chart.lzx
>>>>> M lps/components/charts/linechart/linechart.lzx
>>>>> M lps/components/extensions/views/LzTextFormat.lzx
>>>>>
>>>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080324-dda-f.tar
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Don Anderson
>>>>> Java/C/C++, Berkeley DB, systems consultant
>>>>>
>>>>> voice: 617-547-7881
>>>>> email: dda at ddanderson.com
>>>>> www: http://www.ddanderson.com
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>>
>>> Don Anderson
>>> Java/C/C++, Berkeley DB, systems consultant
>>>
>>> voice: 617-547-7881
>>> email: dda at ddanderson.com
>>> www: http://www.ddanderson.com
>>>
>>>
>>>
>>>
>>
>
--
Don Anderson
Java/C/C++, Berkeley DB, systems consultant
voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com
More information about the Laszlo-dev
mailing list