[Laszlo-dev] For Review: Change 20080307-ptw-x Summary: Stop infinite recursion in baseslider

[P T Withington]

Interestingly, with my latest patch, I have to back this change out to  
avoid recursion!

Clearly this is very fragile code.

On 2008-03-08, at 02:11 EST, Max Carlson wrote:

> Approved!
>
> P T Withington wrote:
>> Change 20080307-ptw-x by ptw at dueling-banjos.local on 2008-03-07  
>> 15:16:34 EST
>>    in /Users/ptw/OpenLaszlo/ringding
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>> Summary: Stop infinite recursion in baseslider
>> Bugs Fixed:
>> LPP-5570 'Circular constraints break swf instantiation'
>> Technical Reviewer: max (pending)
>> QA Reviewer: steele at osteele.com (pending)
>> Details:
>>    Initialize basesliderthumb#x so we don't end up comparing to NaN  
>> in setX to break recursion
>> Tests:
>>    Test case from bug
>> Files:
>> M      lps/components/base/baseslider.lzx
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080307-ptw-x.tar
>
> -- 
> Regards,
> Max Carlson
> OpenLaszlo.org