[Laszlo-dev] [Laszlo-checkins] r8189 - in, openlaszlo/trunk/lps/components: base incubator/rich-text

[André Bargull]

I cannot reproduce the bug from LPP-5550 in my local trunk-branch.
But I guess I could reproduce it with a version prior to rev. #8090, 
because in that revision you've changed the initialization of 
"LzFocus.focuswithkey":
Beforehand "LzFocus.focuswithkey" was set to null and in conjunction 
with the "onfocus"-handler in basefocusview, "active" could be set to 
null, too.

> LzFocus.focuswithkey = null;
+
> <handler args="v" name="onfocus" reference="LzFocus">
>     this.setActive( LzFocus.focuswithkey );
>     [...]
=
/debug-warning/

> It seems so. Maybe you need to enable bactrace and see why someone was  
> setting it to null?
>
> On Mar 6, 2008, at 17:33, Max Carlson <max at openlaszlo.org> wrote:
>
>   
>> > From the source:
>> >        <!--- true during keyboard navigation, when this view is  
>> > visible
>> >              @keywords readonly -->
>> >        <attribute name="active"    value="false" setter="setActive 
>> > (active)"/>
>> >
>> > .active shoudl be defined, no?
>> >
>> > Gah, I changed a handler to a method event...  I'll have to fix that!
>> >
>> > P T Withington wrote:
>>     
>>> >> That's sort of the cheaty solution.  The real bug is probably  
>>> >> that .active is not declared or initialized, so the first time  
>>> >> though you would get a warning from setVisible.  That will need to  
>>> >> be fixed for JS2 compilers which will whine about non-existent  
>>> >> properties.
>>> >> On 2008-03-06, at 00:13 EST, max at openlaszlo.org wrote:
>>>       
>>>> >>> Author: max
>>>> >>> Date: 2008-03-05 21:13:20 -0800 (Wed, 05 Mar 2008)
>>>> >>> New Revision: 8189
>>>> >>>
>>>> >>> Modified:
>>>> >>>  openlaszlo/trunk/lps/components/base/basefocusview.lzx
>>>> >>>  openlaszlo/trunk/lps/components/incubator/rich-text/ 
>>>> >>> baserichedittext.lzx
>>>> >>> Log:
>>>> >>> Change 20080305-maxcarlson-U by maxcarlson at Roboto on 2008-03-05  
>>>> >>> 18:27:34 PST
>>>> >>>   in /Users/maxcarlson/openlaszlo/trunk
>>>> >>>   for http://svn.openlaszlo.org/openlaszlo/trunk
>>>> >>>
>>>> >>> Summary: Update basefocusview to use setVisibility(), fix  
>>>> >>> baserichedittext compilation error
>>>> >>>
>>>> >>> New Features:
>>>> >>>
>>>> >>> Bugs Fixed: LPP-5550
>>>> >>>
>>>> >>> Technical Reviewer: promanik
>>>> >>> QA Reviewer: enw at laszlosystems.com
>>>> >>> Doc Reviewer: (pending)
>>>> >>>
>>>> >>> Documentation:
>>>> >>>
>>>> >>> Release Notes:
>>>> >>>
>>>> >>> Details: baserichedittext.lzx - Remove duplicate name attribute
>>>> >>>
>>>> >>> basefocusview.lzx - Use setVisibility() instead of setVisible()
>>>> >>>
>>>> >>>
>>>> >>> Tests: See LPP-5550
>>>> >>>
>>>> >>>
>>>> >>>
>>>> >>> Modified: openlaszlo/trunk/lps/