[Laszlo-dev] [Laszlo-checkins] r8189 - in openlaszlo/trunk/lps/components: base incubator/rich-text

[P T Withington]

It seems so. Maybe you need to enable bactrace and see why someone was  
setting it to null?

On Mar 6, 2008, at 17:33, Max Carlson <max at openlaszlo.org> wrote:

> From the source:
>        <!--- true during keyboard navigation, when this view is  
> visible
>              @keywords readonly -->
>        <attribute name="active"    value="false" setter="setActive 
> (active)"/>
>
> .active shoudl be defined, no?
>
> Gah, I changed a handler to a method event...  I'll have to fix that!
>
> P T Withington wrote:
>> That's sort of the cheaty solution.  The real bug is probably  
>> that .active is not declared or initialized, so the first time  
>> though you would get a warning from setVisible.  That will need to  
>> be fixed for JS2 compilers which will whine about non-existent  
>> properties.
>> On 2008-03-06, at 00:13 EST, max at openlaszlo.org wrote:
>>> Author: max
>>> Date: 2008-03-05 21:13:20 -0800 (Wed, 05 Mar 2008)
>>> New Revision: 8189
>>>
>>> Modified:
>>>  openlaszlo/trunk/lps/components/base/basefocusview.lzx
>>>  openlaszlo/trunk/lps/components/incubator/rich-text/ 
>>> baserichedittext.lzx
>>> Log:
>>> Change 20080305-maxcarlson-U by maxcarlson at Roboto on 2008-03-05  
>>> 18:27:34 PST
>>>   in /Users/maxcarlson/openlaszlo/trunk
>>>   for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Update basefocusview to use setVisibility(), fix  
>>> baserichedittext compilation error
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-5550
>>>
>>> Technical Reviewer: promanik
>>> QA Reviewer: enw at laszlosystems.com
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details: baserichedittext.lzx - Remove duplicate name attribute
>>>
>>> basefocusview.lzx - Use setVisibility() instead of setVisible()
>>>
>>>
>>> Tests: See LPP-5550
>>>
>>>
>>>
>>> Modified: openlaszlo/trunk/lps/components/base/basefocusview.lzx
>>> ===================================================================
>>> --- openlaszlo/trunk/lps/components/base/basefocusview.lzx     
>>> 2008-03-06 03:47:07 UTC (rev 8188)
>>> +++ openlaszlo/trunk/lps/components/base/basefocusview.lzx     
>>> 2008-03-06 05:13:20 UTC (rev 8189)
>>> @@ -82,7 +82,7 @@
>>>            if ( this.target ) this.setTarget( null )
>>>
>>>            // Make sure this focusview is visible if it is active
>>> -               this.setVisible( this.active );
>>> +               this.setVisibility 
>>> ( this.active?'visible':'hidden' );
>>>
>>>            // store the target that the focusview will be  
>>> constrained to when
>>>            // it stops animating.
>>> @@ -115,7 +115,7 @@
>>>
>>>                // fade in the brackets to balance out the fade out
>>>                if (this.sprite && this.sprite['quirks'] &&  
>>> this.sprite.quirks['minimize_opacity_changes']) {
>>> -                    this.setVisible(true);
>>> +                    this.setVisibility( 'visible' );
>>>                } else {
>>>                    this.animate('opacity', 1, 500);
>>>                }
>>> @@ -149,7 +149,7 @@
>>>        ]]> </method>
>>>
>>>        <!--- @keywords private -->
>>> -        <handler name="onstop" method="stopanim" />
>>> +        <handler name="onstop" method="stopanim"/>
>>>        <method name="stopanim" >  <![CDATA[
>>>            this._animatorcounter -= 1;
>>>            if ( this._animatorcounter < 1 ) {
>>> @@ -171,7 +171,7 @@
>>>        <method name="fadeout" >
>>>            if (_dofadeout) {
>>>                if (this.sprite &amp;&amp; this.sprite['quirks']  
>>> &amp;&amp; this.sprite.quirks['minimize_opacity_changes']) {
>>> -                    this.setVisible(false);
>>> +                    this.setVisibility( 'hidden' );
>>>                } else {
>>>                    this.animate( 'opacity' ,0 , 500);
>>>                }
>>> @@ -257,7 +257,7 @@
>>>        </method>
>>>
>>>        <!--- @keywords private -->
>>> -        <handler args="v" name="onfocus" reference="LzFocus">
>>> +        <method args="v" event="onfocus" reference="LzFocus">
>>>            this.setActive( LzFocus.focuswithkey );
>>>            if ( v ) {
>>>                this.doFocus( v );
>>> @@ -267,7 +267,7 @@
>>>                     this.setActive(false);
>>>                }
>>>            }
>>> -        </handler>
>>> +        </method>
>>>
>>>    </class>
>>>
>>>
>>> Modified: openlaszlo/trunk/lps/components/incubator/rich-text/ 
>>> baserichedittext.lzx
>>> ===================================================================
>>> --- openlaszlo/trunk/lps/components/incubator/rich-text/ 
>>> baserichedittext.lzx    2008-03-06 03:47:07 UTC (rev 8188)
>>> +++ openlaszlo/trunk/lps/components/incubator/rich-text/ 
>>> baserichedittext.lzx    2008-03-06 05:13:20 UTC (rev 8189)
>>> @@ -32,7 +32,7 @@
>>>            if (parent['onblur']) parent.onblur.sendEvent(s);
>>>        </handler>
>>>        <!--- Sent whenever a user enters a valid new character. -->
>>> -        <handler name="ontext" name="doOnText">
>>> +        <handler name="ontext">
>>>            if (! this.ignorecallup) {
>>>                parent.setValue(this.getText(),false,true);
>>>            }
>>>
>>>
>>> _______________________________________________
>>> Laszlo-checkins mailing list
>>> Laszlo-checkins at openlaszlo.org
>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
>
> -- 
> Regards,
> Max Carlson
> OpenLaszlo.org