[Laszlo-dev] For Review: Change 20080306-dda-c Summary: SWF9: fix functions nested within functions

[Donald Anderson]

Change 20080306-dda-c by dda at lester.local on 2008-03-06 10:50:52 EST
     in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildogm
     for http://svn.openlaszlo.org/openlaszlo/branches/devildog

Summary: SWF9: fix functions nested within functions

New Features:

Bugs Fixed: LPP-5555

Technical Reviewer: ptw (pending)
QA Reviewer: hminsky (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
     Error occured because the a parse tree for the inner function was:
        ModifiedDefinition
          FunctionDefinition(func)
     This is transformed to be as if it was written like this func =  
function () { ... };
     The transformation moves everything under the FunctionDefinition  
into a FunctionExpression clause,
     and replaces the FunctionDefinition by an empty expression.  The  
EmptyExpression was
     not correctly handled by the checks on ModifiedDefinition.  We  
now allow EmptyExpression,
     but verify that there are no modifiers (like public/static/final)  
on the inner function.

     Also fixed setting the default canvas height if it is not set in  
the options.
     This permits simple test cases to be run to completion on the  
command line.

Tests:

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/ 
ASTModifiedDefinition.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080306-dda-c.tar



--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com