[Laszlo-dev] For Review: 20080626-laszlo-8 Summary: Time in calendar can be changed to end before it starts

[J Crowley]

Ah, thanks.

1) Yeah, this is unrelated, and is in part because the 'active event' is 
actually a different object that exists outside of the days and is 
therefore not clipped by their views, I think, like the other events 
are.  I'll file this in JIRA.

2) Ah, good catch.  Forgot about editing the start time.  I'll fix 
this.  Thanks!

Philip Romanik wrote:
> I found a couple of issues.
>
> - If you create a new event you can edit the start/stop time such that 
> the event is displayed outside the area for that day. I don't think 
> this behavior is caused by this changeset but I figured I would ask. 
> If it is old behavior can you create a jira task for it.
>
> - Expand the stop time until it hits 11:45 pm. If you edit the start 
> time in the infopanel, the end time is adjusted incorrectly.
>
>
>
>> Change 20080626-laszlo-8 by laszlo at T43-L3XEXMW on 2008-06-26 14:16:10 EDT
>>     in /home/laszlo/src/svn/openlaszlo/trunk-liquid
>>     for http://svn.openlaszlo.org/openlaszlo/trunk
>>  
>> Summary: Time in calendar can be changed to end before it starts
>>  
>> New Features:
>>  
>> Bugs Fixed: LPP-6315 - Time in calendar can be changed to end before 
>> it starts
>>  
>> Technical Reviewer: max
>> QA Reviewer: promanik
>> Doc Reviewer: (pending)
>>  
>> Documentation:
>>  
>> Release Notes:
>>  
>> Details: Since events aren't really designed, currently, to be
>>     spread across multiple days, I limited events so that they
>>     can't run over into the next day.  Having multi-day events
>>     would require too dramatic an overhaul to the entire app.
>>    
>>     Also, there was a weird issue with the time being a half an
>>     hour off, which was the result of the background grid being
>>     pushed down a bit so that "12AM" wasn't clipped at the top.
>>     I could've either adjusted the grid so that it WAS clipped,
>>     or changed the events to compensate, so I did the latter.
>>  
>> Tests: Open Calendar in SWF or DHTML.  Create a new event, or
>>     edit an existing event.  Click the time arrow.  The event
>>     end time should stop before spilling over into the next day.
>>     If you drag the event to a later time, the end time should
>>     auto-adjust so that it doesn't spill over into the next day
>>     as well.  (You can't create an eight-hour event at noon and
>>     then drag it to 9 PM and have it run into the next day at
>>     eight hours in length.)
>>    
>>     Also, when the day is expanded, the events should now be at
>>     the right time on the time grid, instead of half an hour off.
>>  
>> Files:
>> M      demos/calendar/cal-data.lzx
>> M      demos/calendar/event.lzx
>>  
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20080626-laszlo-8.tar