[Laszlo-dev] For Review: Change 20080624-ptw-O Summary: Fix brain-oh's in DHTML text measurement

[André Bargull]

I'm going to create a testcase, so we can compare swf<->dhtml more 
easily (and then determine when to use scrollHeight/clientHeight).


On 6/24/2008 7:40 PM, André Bargull wrote:
>> And why the change from this.__LzInputDiv.scrollHeight to 
>> this.__LzInputDiv.clientHeight in LzInputtextSprite.js
> Absolutely necessary, just compare it to the swf-version of 
> "LzTextSprite#getTextfieldHeight()".
>
>
> On 6/24/2008 7:27 PM, Max Carlson wrote:
>> It's really close - I think you're off by 1 for inputtext placement.
>>
>> From 
>> http://localhost:8080/trunk-clean/examples/components/component_sampler.lzx?lzt=testboth: 
>>
>>
>>
>> From 
>> http://localhost:8080/trunk-clean/examples/components/edittext_example.lzx?lzt=testboth: 
>>
>>
>>
>> Also, you can see scrollbars no longer show up in Firefox 3 for 
>> multiline edittext in dhtml which makes them harder to edit.  
>> Scrollbars do show in IE 7 DHTML.
>>
>> And why the change from this.__LzInputDiv.scrollHeight to 
>> this.__LzInputDiv.clientHeight in LzInputtextSprite.js?
>>
>> P T Withington wrote:
>>> Change 20080624-ptw-O by ptw at dueling-banjos.local on 2008-06-24 
>>> 11:49:05 EDT
>>>     in /Users/ptw/OpenLaszlo/ringding-clean
>>>     for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Fix brain-oh's in DHTML text measurement
>>>
>>> Bugs Fixed:
>>> LPP-6451 'LPP-6451 'SWF and DHTML: Text entered into the weather app 
>>> and edittext component is not vertically centered (too high).'
>>>
>>> Technical Reviewer: hminsky (pending), a.bargull at intensis.de (pending)
>>> QA Reviewer: max (pending)
>>>
>>> Details:
>>>     LzTextSprite, LzInputTextSprite: share getTextHeight, use a common
>>>     algorithm for getTextfieldHeight.  With these changes,
>>>     getText{,field}{Height,Width} return the same values for swf and
>>>     dhtml in the edittext example.
>>>
>>> Tests:
>>>     Weather and edittext examples look right now in DHTML too.
>>>
>>> Files:
>>> M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
>>> M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
>>>
>>> Changeset: 
>>> http://svn.openlaszlo.org/openlaszlo/patches/20080624-ptw-O.tar
>>
>> -- 
>> Regards,
>> Max Carlson
>> OpenLaszlo.org
>