[Laszlo-dev] For Review: Change 20080624-ptw-a Summary: Revert brain-oh's in text measurement

[André Bargull]

Approved for swf,

but if you compare swf<->dhtml, you still see some differences:
- your change in r9824 for "LzInputtextSprite.js" wasn't reverted
- "LzInputTextSprite.prototype.getTextfieldHeight" just doesn't make any 
sense:
    (i) it doesn't track any text-formatting changes
    (ii) and it /tries/ to cache values, but fails gracefully, because 
it caches the return-value from "getTextSize(..)" in the 
"fieldHeight"-member,
          but in the first round it adds the 
"quirks.emulate_flash_font_metrics" 4px-padding, but later it doesn't do 
that anymore!

I've attached sample screenshots and my modified version of 
"LzInputtextSprite.js" (which still yields different results for 
inputtexts with zero-height, though).

On 6/24/2008 4:25 PM, P T Withington wrote:
> Change 20080624-ptw-a by ptw at dueling-banjos.local on 2008-06-24 
> 08:20:50 EDT
>     in /Users/ptw/OpenLaszlo/ringding-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Revert brain-oh's in text measurement
>
> Bugs Fixed:
> LPP-6451 'SWF and DHTML: Text entered into the weather app and 
> edittext component is not vertically centered (too high).'
>
> Technical Reviewer: a.bargull at intensis.de, hminsky (pending)
> QA Reviewer: Helgeson.Jeremy at gmail.com (pending)
>
> Details:
>     Revert my brain-oh where I did not understant the relationship
>     between _height and textHeight in swf and got them backwards.  Add
>     more @devnotes so I don't do that again...
>
> Tests:
>     Weather and edittext examples look right now
>
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
>
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080624-ptw-a.tar
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LzInputTextSprite.js
Type: application/x-javascript
Size: 36380 bytes
Desc: not available
Url : http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080624/ee2488fc/LzInputTextSprite-0001.js
-------------- next part --------------
A non-text attachment was scrubbed...
Name: swf_edittext_sample.png
Type: image/png
Size: 6950 bytes
Desc: not available
Url : http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080624/ee2488fc/swf_edittext_sample-0001.png
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dhtml_edittext_sample.png
Type: image/png
Size: 6908 bytes
Desc: not available
Url : http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080624/ee2488fc/dhtml_edittext_sample-0001.png
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dhtml_edittext_sample_modified.png
Type: image/png
Size: 6950 bytes
Desc: not available
Url : http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080624/ee2488fc/dhtml_edittext_sample_modified-0001.png