[Laszlo-dev] [Laszlo-checkins] r9751 - openlaszlo/trunk/demos/amazon

[J Crowley]

I think it was a matter of dragging it into the tab's contents as 
opposed to dragging it into the tab as a whole, which would include the 
tab's bar/header.

P T Withington wrote:
> Was this a regression?  Do we understand why you had to change the 
> reference to parent.parent?
>
> If this is a regression, I'm concerned that something in the core 
> changed that will affect other users.
>
> On 2008-06-18, at 03:36 EDT, jcrowley at openlaszlo.org wrote:
>
>> Author: jcrowley
>> Date: 2008-06-18 00:35:58 -0700 (Wed, 18 Jun 2008)
>> New Revision: 9751
>>
>> Modified:
>>   openlaszlo/trunk/demos/amazon/amazon.lzx
>> Log:
>> Change 20080617-laszlo-4 by laszlo at T43-L3XEXMW on 2008-06-17 15:45:06 
>> EDT
>>    in /home/laszlo/src/svn/openlaszlo/trunk-six
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: BluePrint Music: Dragging large album icon (from info) onto 
>> Shopping Cart Vertical Tab is not recognized.
>>
>> New Features:
>>
>> Bugs Fixed: LPP-4858 - BluePrint Music: Dragging large album icon 
>> (from info) onto Shopping Cart Vertical Tab is not recognized.
>>
>> Technical Reviewer: phil
>> QA Reviewer: max
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: Applied the same fix I used a while back from the 
>> recommendations
>>    panel to the info panel.  Also fixed it when dragging between Cart 
>> and
>>    Wish List panels, since it was broken there, too, and fixed an 
>> 'undefined'
>>    warning.
>>
>> Tests: Run Amazon demo.  Click on the (i) button for any of the 
>> albums.  Drag
>>    the album cover from the info panel that pops up over the Cart 
>> bar.  It
>>    should bounce, and the item should be added to the panel.  Repeat 
>> for Wish
>>    List.  Then, open up Wish List, drag an item into Cart.  The Cart bar
>>    should bounce, and the item should be added.  Then close Wish List 
>> and open
>>    Cart and do the same thing.  Wish List's bar should bounce, and 
>> the items
>>    should be added.
>>
>>
>>
>> Modified: openlaszlo/trunk/demos/amazon/amazon.lzx
>> ===================================================================
>> --- openlaszlo/trunk/demos/amazon/amazon.lzx    2008-06-18 03:20:04 
>> UTC (rev 9750)
>> +++ openlaszlo/trunk/demos/amazon/amazon.lzx    2008-06-18 07:35:58 
>> UTC (rev 9751)
>> @@ -198,9 +198,9 @@
>>                             
>> ondblclick="cart.addItem(parent.parent.datapath)">
>>                             <attribute name="source" 
>> value="${this.data}"/>
>>                             <method name="itemDropped" args="dpath">
>> -                                if 
>> (dragger.droppedInView(cart.parent)) {
>> +                                if 
>> (dragger.droppedInView(cart.parent.parent)) {
>>                                     cart.addItem(dpath);
>> -                                } else if 
>> (dragger.droppedInView(wish.parent)) {
>> +                                } else if 
>> (dragger.droppedInView(wish.parent.parent)) {
>>                                     wish.addItem(dpath);
>>                                 }
>>                             </method>
>> @@ -250,7 +250,7 @@
>>                                         <![CDATA[
>>                                         var discs = 
>> this.datapath.xpathQuery('Disc')
>>                                         if (! discs) return;
>> -                                        if (! discs.length) discs = 
>> [ discs ];
>> +                                        if (! discs['length']) discs 
>> = [ discs ];
>>                                         var tracks = 0;
>>                                         for (i in discs) {
>>                                             var n = discs[i];
>> @@ -364,10 +364,10 @@
>>                         <shoppinglist id="cart" datapath="dsCart:/"
>>                                       
>> panel_to_nudge="$once{parent.parent}">
>>                             <method name="itemDropped" args="dpath">
>> -                                if 
>> (dragsmall.droppedInView(wish.parent)) {
>> +                                if 
>> (dragsmall.droppedInView(wish.parent.parent)) {
>>                                     wish.addItem(dpath);
>>                                     this.removeItem(dpath);
>> -                                } else if 
>> (!dragsmall.droppedInView(cart.parent)) {
>> +                                } else if 
>> (!dragsmall.droppedInView(cart.parent.parent)) {
>>                                     this.removeItem(dpath);
>>                                 } else if 
>> (dragsmall.droppedInTrash(cart.trashCan) ){
>>                                     this.removeItem(dpath);
>> @@ -386,13 +386,13 @@
>>                         <shoppinglist id="wish" datapath="dsWish:/"
>>                                       
>> panel_to_nudge="$once{parent.parent}">
>>                             <method name="itemDropped" args="dpath">
>> -                                if 
>> (dragsmall.droppedInView(cart.parent)) {
>> +                                if 
>> (dragsmall.droppedInView(cart.parent.parent)) {
>>                                     cart.addItem(dpath);
>>                                     this.removeItem(dpath);
>>                                 } else if 
>> (dragsmall.droppedInTrash(wish.trashCan) ){
>>                                     this.removeItem(dpath);
>>                                     return
>> -                                } else if 
>> (!dragsmall.droppedInView(wish.parent)) {
>> +                                } else if 
>> (!dragsmall.droppedInView(wish.parent.parent)) {
>>                                     this.removeItem(dpath);
>>                                 }
>>                             </method>
>>
>>
>> _______________________________________________
>> Laszlo-checkins mailing list
>> Laszlo-checkins at openlaszlo.org
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
>
>