[Laszlo-dev] For Review: Change 20080617-hqm-f Summary: update LzReplicationManager to use new setter convention for 'visible'

[André Bargull]

Approved.

Tucker's comment at "LzReplicationManager#setVisible(..)" is now 
obsolete and can be removed.

> // TODO [hqm 2008-06-17] why do we need to handle this case
> // explicitly?  When is this.visible going to be false at
> // construct time on a replication manager?
It could be set to false in LzReplicationManager#construct(..), if the 
actual logic was working.
But the if-condition "odp.datacontrolsvisibility" is always true, 
because that attribute has been deprecated [1], so no one should work 
with it anymore,
but the default value is still "true" (see in LzDatapath.lzs).....
> //set visible-property
>     if (*odp.datacontrolsvisibility*) {
>         this.visible = true;
>     } else {
>         [...]
>     }


[1] LPP-6048.lzx:28:86: found an unknown attribute named 
"datacontrolsvisibility" on element datapath, check the spelling of this 
attribute name


On 6/17/2008 8:40 PM, Henry Minsky wrote:
> Change 20080617-hqm-f by hqm at badtzmaru.home on 2008-06-17 13:44:55 EDT
>     in /Users/hqm/openlaszlo/trunk4/WEB-INF/lps/lfc
>     for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc
>
> Summary: update LzReplicationManager to use new setter convention for 
> 'visible'
>
> New Features:
>
> Bugs Fixed: LPP-6048
>
> Technical Reviewer: a.bargull
> QA Reviewer: pbr
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
>
> Tests:
>
> smokecheck
>
>
> Files:
> M      data/LzReplicationManager.lzs
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080617-hqm-f.tar
>