[Laszlo-dev] For Review: Change 20080610-laszlo-4 Summary: Run migration script on demos to prevent warnings

[André Bargull]

Sure, then it's approved!


On 6/12/2008 4:49 AM, J Crowley wrote:
> These are all excellent catches, Andre. Thanks!  I knew there were
> things I didn't catch from checking through what the script did.  Do
> you approve, then, provided I fix these issues first?
> On 6/11/08, André Bargull <a.bargull at intensis.de> wrote:
>   
>> I'm not d'accord with the changes for "LzMouseKernel#restoreCursor()".
>> You should add a new function to LzSprite (swf) which redirects to
>> "LzMouseKernel#restoreCursor()", see
>> "http://www.openlaszlo.org/pipermail/laszlo-dev/2008-May/014612.html".
>>
>> gridcolumn.lzx:
>> I don't understand why you've added this check, if 'parent.resizer' is
>> undefined (you want to test against this condition, right?!), you also
>> cannot access 'width'.
>>     
>>> -  parent.resizer.width : 0 ) }"/>
>>> + parent['resizer'].width : 0 ) }"/>
>>>       
>> lztestmanager.lzx:
>> needs to be "apply(..)", 'testcaseObj' is not a state, it's a function!
>>     
>>> -  testcaseObj.apply(suiteObj);
>>> + testcaseObj.setAttribute('applied', true);
>>>       
>> lps/components/extensions/html.lzx:
>> really needs to be "setVisible(..)" and not "setAttribute('visible', ..)"
>>
>> lps/components/extensions/av/rtmpconnection.lzx:
>> wrong, not a state!
>>
>> baselist.lzx:
>> you can't check enough a condition!?
>>     
>>> -          if (this._hiliteview && this._hiliteview.setHilite) {
>>> +          if (this._hiliteview && this._hiliteview['setHilite'] &&
>>> this._hiliteview.setHilite) {
>>>       
>> demos/amazon-soap/classlib.lzx:
>> that should be: "if (! this['__closeDel')) {...}"
>>     
>>> -  if (! this.__closeDel) this.__closeDel = new LzDelegate(this,
>>> 'hidecontent', a, 'onstop');
>>> + if (this['__closeDel'] && ! this.__closeDel) this.__closeDel = new
>>> LzDelegate(this, 'hidecontent', a, 'onstop');
>>>       
>> demos/lzproject/lzx/lzproject/LZProject.lzx:
>> => if (tasks is LzReplicationManager)
>>     
>>> -  if (tasks.constructor.classname == "LzReplicationManager") {
>>> + if (tasks.constructor.tagname == "LzReplicationManager") {
>>>       
>> examples/image-loading/dataimage.lzx:
>> there are still getAttribute(..) calls:
>>     
>>>                              "width",*yellowRect.getAttribute("width")
>>> *- 2);
>>>              yellowRect.setAttribute(
>>>
>>> "height",*yellowRect.getAttribute("height") *- 2);
>>> -            yellowRect.setVisible(true);
>>> +            yellowRect.setAttribute('visible', true);
>>>       
>> The update script really should respect whitespaces..
>> (there are two whitespace chars before 'false' in the updated line)
>>     
>>> -  recommend.setVisible( false );
>>> + recommend.setAttribute('visible',  false );
>>>       
>>
>> On 6/11/2008 3:06 AM, J Crowley wrote:
>>     
>>> Change 20080610-laszlo-4 by laszlo at T43-L3XEXMW on 2008-06-10 20:47:19 EDT
>>>    in /home/laszlo/src/svn/openlaszlo/trunk-four
>>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Run migration script on demos to prevent warnings
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-6060 - Run migration script on demos to prevent warnings
>>>
>>> Technical Reviewer: phil
>>> QA Reviewer: andre
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details: Ran the migration script on the demos, examples, et cetera,
>>>    but also ran it on the components, since there are a lot of
>>> setVisible()
>>>    and apply() and remove() methods throughout all of those, which were
>>>    manifesting as warnings in the demos and examples and things.
>>>       Also fixed a bunch of other errors and warnings I discovered along
>>>    the way.
>>>       In the process, I discovered that the migration script changes
>>> every
>>>    method that starts with "apply" or "remove" and not just "apply()" and
>>>    "remove()" themselves, so had to sort through a diff of everything
>>> that
>>>    was changed to switch back methods like "applyData" and
>>> "removeView" and
>>>    such.  It also truncated method declarations in certain cases.
>>> Filed as
>>>    LPP-6208.
>>>
>>> Tests: Run the demos, the examples, and all the stuff in
>>> laszlo-explorer with
>>>    the Debugger on.  There should now be no warnings or errors along
>>> the lines
>>>    of "use setAttribute('visible') instead" or "use
>>> setAttribute('apply', false)
>>>    instead", or etc.
>>>       Also, the tests for components should all still pass.  (I fixed
>>> a couple
>>>    errors/warnings I found in a few of the test files, but not all of
>>> them.)
>>>       The Amazon-SOAP demo doesn't currently work, but for a different
>>> reason.
>>>    (Filed as LPP-6143.)  Videolibrary doesn't seem to work either; I'm
>>> looking
>>>    into it, and will file a bug.  There are a bunch of errors and
>>> warnings in
>>>    LzProject, and I'm going to file a bug to deal with all of those on
>>> their
>>>    own.
>>>
>>> Files:
>>> M      test/components/lz/colorcontrol.lzx
>>> M      test/components/layouttest.lzx
>>> M      WEB-INF/lps/lfc/kernel/swf/LzMouseKernel.as
>>> M      WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
>>> M      lps/components/queens-charts/barchart.lzx
>>> M      lps/components/queens-charts/linechart.lzx
>>> M      lps/components/queens-charts/shared/chartzoomer.lzx
>>> M      lps/components/charts/columnchart/columnchartplotarea.lzx
>>> M      lps/components/charts/addon/slider/slider.lzx
>>> M      lps/components/charts/addon/zoomarea.lzx
>>> M      lps/components/charts/barchart/barchartplotarea.lzx
>>> M      lps/components/charts/common/axis.lzx
>>> M      lps/components/charts/common/datamarker.lzx
>>> M      lps/components/charts/common/label.lzx
>>> M      lps/components/charts/common/valueregion.lzx
>>> M      lps/components/charts/common/viewspoolmanager.lzx
>>> M      lps/components/charts/common/datatip.lzx
>>> M      lps/components/charts/common/chart.lzx
>>> M      lps/components/debugger/debugger.lzx
>>> M      lps/components/debugger/newcontent.lzx
>>> M      lps/components/debugger/scrollingtext.lzx
>>> M      lps/components/lz/gridcolumn.lzx
>>> M      lps/components/lz/mr-ed.lzx
>>> M      lps/components/lz/modaldialog.lzx
>>> M      lps/components/lz/tabelement.lzx
>>> M      lps/components/lz/menu.lzx
>>> M      lps/components/lz/datepicker.lzx
>>> M      lps/components/lztest/lztestmanager.lzx
>>> M      lps/components/lzunit/lzunit.lzx
>>> M      lps/components/incubator/custombutton.lzx
>>> M      lps/components/incubator/tooltip/tooltip.lzx
>>> M      lps/components/incubator/newvscrollbar.lzx
>>> M      lps/components/incubator/iconradioitem.lzx
>>> M      lps/components/incubator/baseslider.lzx
>>> M      lps/components/incubator/stylishbutton.lzx
>>> M      lps/components/incubator/validators/basevalidator.lzx
>>> M      lps/components/incubator/newhscrollbar.lzx
>>> M      lps/components/incubator/test/draglib-test.lzx
>>> M      lps/components/incubator/draglib.lzx
>>> M      lps/components/incubator/opttree/opttree.lzx
>>> M      lps/components/incubator/hsplitpane.lzx
>>> M      lps/components/incubator/vslider.lzx
>>> M      lps/components/incubator/lzeditcombobox.lzx
>>> M      lps/components/incubator/rich-text/test/test-lzcombobox.lzx
>>> M      lps/components/incubator/rich-text/linkdialog.lzx
>>> M      lps/components/incubator/rich-text/formatfontcolor.lzx
>>> M      lps/components/incubator/rich-text/formatfontface.lzx
>>> M      lps/components/extensions/test/html.lzx
>>> M      lps/components/extensions/test/drawing.lzx
>>> M      lps/components/extensions/html.lzx
>>> M      lps/components/extensions/av/mediastream.lzx
>>> M      lps/components/extensions/av/videoview.lzx
>>> M      lps/components/extensions/av/rtmpconnection.lzx
>>> M      lps/components/utils/states/dragstate.lzx
>>> M      lps/components/utils/states/resizestate.lzx
>>> M      lps/components/utils/diagnostic/inspector/colormenu.lzx
>>> M      lps/components/utils/diagnostic/inspector/inspector.lzx
>>> M      lps/components/utils/diagnostic/versioninfo.lzx
>>> M      lps/components/base/basescrollbar.lzx
>>> M      lps/components/base/basecomponent.lzx
>>> M      lps/components/base/basewindow.lzx
>>> M      lps/components/base/submit.lzx
>>> M      lps/components/base/basecombobox.lzx
>>> M      lps/components/base/baselist.lzx
>>> M      lps/components/base/baseslider.lzx
>>> M      lps/components/base/basegrid.lzx
>>> M      lps/components/base/basedatacombobox.lzx
>>> M      lps/components/base/style.lzx
>>> M      laszlo-explorer/coverpages/welcome/clock.lzx
>>> M      laszlo-explorer/coverpages/welcome/cityspot.lzx
>>> M      laszlo-explorer/coverpages/welcome/rclock/clock.lzx
>>> M      laszlo-explorer/inspector/colormenu.lzx
>>> M      laszlo-explorer/inspector/inspector.lzx
>>> M      laszlo-explorer/inspector/colormenu-test.lzx
>>> M      laszlo-explorer/constraints/splitpanel.lzx
>>> M      laszlo-explorer/constraints/dragdrop.lzx
>>> M      laszlo-explorer/basics/states.lzx
>>> M      laszlo-explorer/basics/drag-and-drop.lzx
>>> M      laszlo-explorer/explore-nav.lzx
>>> M      demos/amazon/amazon.lzx
>>> M      demos/amazon/classlib.lzx
>>> M      demos/amazon-soap/recommendation.lzx
>>> M      demos/amazon-soap/amazon.lzx
>>> M      demos/amazon-soap/classlib.lzx
>>> M      demos/lzpix/classes/draggedphotos.lzx
>>> M      demos/lzpix/views/tools.lzx
>>> M      demos/noughts/noughts.lzx
>>> M      demos/lzproject/derby/lzprojectdb/log/logmirror.ctrl
>>> M      demos/lzproject/derby/lzprojectdb/log/log.ctrl
>>> M      demos/lzproject/derby/lzprojectdb/log/log1.dat
>>> M      demos/lzproject/derby/lzprojectdb/seg0/c4e0.dat
>>> M      demos/lzproject/lzx/lzproject/modules/UserCreateEditForm.lzx
>>> M      demos/lzproject/lzx/lzproject/LZProject.lzx
>>> M      demos/lzpixmobile/main.lzx
>>> M      demos/lzpixmobile/classes/photocollection.lzx
>>> M      demos/lzpixmobile/classes/search.lzx
>>> M      demos/lzpixmobile/classes/clipboardinterior.lzx
>>> M      demos/lzpixmobile/classes/mobilescroller.lzx
>>> M      demos/lzpixmobile/classes/photo.lzx
>>> M      demos/lzpixmobile/classes/footerbutton.lzx
>>> M      demos/lzpixmobile/classes/draggedphotos.lzx
>>> M      demos/lzpixmobile/classes/clipboard.lzx
>>> M      demos/lzpixmobile/classes/pivotlayout.lzx
>>> M      demos/lzpixmobile/views/clips.lzx
>>> M      demos/lzpixmobile/views/photodetails.lzx
>>> M      demos/lzpixmobile/views/optionsmenu.lzx
>>> M      examples/music/music.lzx
>>> M      examples/paging.lzx
>>> M      examples/components/testmedia/frosty.lzx
>>> M      examples/components/floatinglist_example.lzx
>>> M      examples/components/menu_example.lzx
>>> M      examples/components/scrollbar_example.lzx
>>> M      examples/components/grid_example.lzx
>>> M      examples/css/chocolate.css
>>> M      examples/css/berry.css
>>> M      examples/css/test.lzx
>>> M      examples/css/haze.css
>>> M      examples/xmldata/xmldata.lzx
>>> M      examples/image-loading/dataimage.lzx
>>> M      examples/systemprop.lzx
>>> M      examples/mobile/clock/clock.lzx
>>> M      examples/path-attribute.lzx
>>> M      examples/modeexample.lzx
>>>
>>> Changeset:
>>> http://svn.openlaszlo.org/openlaszlo/patches/20080610-laszlo-4.tar
>>>
>>>
>>>       
>
>