[Laszlo-dev] For Review: Change 20080611-hqm-o Summary: add API for setting proxy server host, for media and for data loading

[André Bargull]

I've started to review this change, but I guess you want to take another 
look on it and make some clean-ups, for instance:
- missing $debug statements
- "Debug.deprecated(this, arguments.callee, *this.searchParents*)" 
doesn't make any sense for LzView#setProxyPolicy(..)
- LzMediaLoader (swf) doesn't work anymore after applying this change

And, there is absolutely no backward-compatibility with the previous 
proxy-mechanism in LzView. Any reason for this?




On 6/11/2008 1:51 PM, Henry Minsky wrote:
> Change 20080611-hqm-o by hqm at badtzmaru.home on 2008-06-11 00:56:42 EDT
>     in /Users/hqm/openlaszlo/trunk4
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: add API for setting proxy server host, for media and for data 
> loading
>
> New Features:
>
> Bugs Fixed: LPP-4449
>
> Technical Reviewer: max
> QA Reviewer: a.bargull
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> + for media loading, LzView now has a proxyurl attribute, which can be 
> either null, a String, or a function which returns a String.
> That string is used as the proxy host for media loads.
>
> + the LzView proxyurl defaults to a function which looks up the proxy 
> url from the canvas.
>
> + The canvas has a proxyurl property, which defaults to the previous 
> behavior, using the application base URL as the
> proxy url.
>
>
> + the kernel LzHTTPLoader implementations all call out to a common 
> routine, LzBrowser.makeProxiedURL, to generate the
> URL which is sent to the proxy server.
>
>
> + LzDataset accepts a new proxyurl attribute, which is passed to 
> LzHTTPDataprovider. LzHTTPDataRequest has a slot to hold
> the proxyurl, and it is passed to the LzHTTPLoader.
>
> + Currently there is not an easy way for the user to override the 
> LzBrowser implementation of makeProxiedURL, so there isn't
> really a way for the user to implement a new proxy protocol. We should 
> come up with an API for this I suppose.
>
>
>
>
>
> Tests:
>
> ant lztest
> test/lfc/data/alldata.lzx
> amazon (proxied/swf, solo/swf, proxied/DHTML)
> calendar (proxied/swf, proxied/dhtml, solo dhtml, solo swf)
>
> Files:
> M      WEB-INF/lps/schema/lfc.lzx
> M      WEB-INF/lps/lfc/kernel/swf/LzHTTPLoader.as
> M      WEB-INF/lps/lfc/kernel/dhtml/LzHTTPLoader.js
> M      WEB-INF/lps/lfc/kernel/swf9/LzHTTPLoader.as
> M      WEB-INF/lps/lfc/services/LzBrowser.lzs
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
> M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
> M      WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
> M      WEB-INF/lps/lfc/data/LzDataset.lzs
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080611-hqm-o.tar
>