[Laszlo-dev] For Review: Change 20080610-bargull-oyd Summary: menu-component for swf9

[André Bargull]

I've added the "this." to that line by perpose, because there was a 
compile-error in swf9 (needs to be investigated, though).
> if ( this.onselect  ) this.onselect.sendEvent();
LzDeclaredEventClass#ready is a LFC-internal flag, so I don't want to 
add it to the components yet.

On 6/11/2008 6:48 AM, Max Carlson wrote:
> Approved!  Note that because all events are declared ahead of time 
> calls like this are useless:
> if ( this.onselect  ) this.onselect.sendEvent();
>
> Since this.onselect is always defined, sendEvent() is called even when 
> there are no listeners.  You can remove the test, or use this idiom to 
> ensure the event has listeners:
> if ( this.onselect.ready  ) this.onselect.sendEvent()
>
> I got a speed boost a while ago when I changed all internal LFC events 
> to check .ready before sending!
>
> André Bargull wrote:
>> Change 20080610-bargull-oyd by bargull at dell--p4--2-53 on 2008-06-10 
>> 22:04:31
>> in /home/Admin/src/svn/openlaszlo/trunk
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: menu-component for swf9
>>
>> New Features:
>>
>> Bugs Fixed: LPP-6163
>>
>> Technical Reviewer: hminsky
>> QA Reviewer: max
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>> LFCApplication: use lz.ModeManager instead of LzModeManager
>> LzTrack: check for valid view (__LZlasthit)
>> listitem: pass current style to _applystyle(..)
>> basefloatinglist: update destroy() method signature, add method to 
>> handle "ondestroy", you can't change a method signature in a subclass 
>> in swf9, so added workaround for _setShownItems(..)
>> hscrollbar, vscrollbar, scrollbar: changed "oninit"-handler to call 
>> _showEnabled()
>> textlistitem: same as listitem
>> menu: simply text-constraint for menubutton, update method signature 
>> for menubutton#showDown(..), add ignore-arg for 
>> menuitem#showSubmenu() and menuitem#hideSubmenu()
>> list: you can't change a method singnature in a subclass in swf9, 
>> therefore added workarounds for setBGColor(..), setHeight(..)
>> basescrollbar: added missing attribute for class, added 'this' to fix 
>> swf9-state bug
>> basetrackgroup: updated construct(..) method signature
>>
>>
>> Tests:
>> attached at bugreport (works now in swf8, swf9, dhtml)
>>
>> Files:
>> M WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as
>> M WEB-INF/lps/lfc/services/LzTrack.lzs
>> M lps/components/lz/listitem.lzx
>> M lps/components/lz/basefloatinglist.lzx
>> M lps/components/lz/hscrollbar.lzx
>> M lps/components/lz/textlistitem.lzx
>> M lps/components/lz/menu.lzx
>> M lps/components/lz/vscrollbar.lzx
>> M lps/components/lz/list.lzx
>> M lps/components/lz/scrollbar.lzx
>> M lps/components/base/basescrollbar.lzx
>> M lps/components/base/basetrackgroup.lzx
>>
>> Changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20080610-bargull-oyd.tar
>>
>