[Laszlo-dev] For Review: Change 20080606-ptw-1 Summary: Trim some fat

[André Bargull]

Not approved.

Can't compile weather-demo in swf9 anymore, getting "/Found no 
standard-constructor in baseclass LzLayout/":
> |org.openlaszlo.sc.CompilerError: line unknown:
> line unknown: Kein Standardkonstruktor in Basisklasse LzLayout 
> gefunden, in line: package {
> line unknown: Kein Standardkonstruktor in Basisklasse LzState 
> gefunden, in line: package {
>
> |

And compiling weather-demo in swf7-8 shows your deprecate info from 
LzNode#makeChild(..):
> INFO: makeChild.name is deprecated.  Use makeChild.class instead 


On 6/6/2008 3:04 PM, P T Withington wrote:
> Change 20080606-ptw-1 by ptw at dueling-banjos.local on 2008-06-06 
> 06:47:15 EDT
>     in /Users/ptw/OpenLaszlo/ringding-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Trim some fat
>
> Bugs Fixed:
> LPP-6017 'file size of compiled swf applications has gotten
> significantly larger' (partial)
>
> Technical Reviewer: hminsky (pending)
> QA Reviewer: a.bargull at intensis.de (pending)
>
> Details:
>     With these changes, dhtml size is significantly improved, swf not
>     so much.  In the table below, p-d is the pagan-deities sizes, r-d
>     is ring-ding, and now is with this change set
>
>                swf8     dhtml
>     p-d        121k     288k
>     r-d        229k     593k
>     now        210k     361k
>
>     LzNode: makeChild now takes the class to instantiate, instead of a
>     tag.  This allows us to instantiate anonymous classes directly and
>     not clutter the tag table with anonymous class names.  Renamed
>     userClassPlacement to follow internal class names, removed it from
>     the tag table.  (Part of the reason this can work now is that the
>     compiler orders class definitions to emit them before they are
>     used, whereas in the past it did not handle forward references.)
>
>     ReplicationManager: Use class rather than tag to create clones.
>
>     Class: Install class in global (rather than the compiler doing so
>     in-line, to save space).
>
>     CommonGenerator: Simplify argument defaulting code to use `switch`
>     and `Array#slice` rather than multiple `if` clauses and `for`
>     loop.
>
>     *: Rename '[cC]lass[nN]ame' to '[tT]ag[nN]ame', since that is what 
> it really
>     is.  Update map generators and calls to instantiator to pass
>     'class' instead of 'name'.
>
>     NodeModel: If you are not in debug mode, use short, unique names
>     for methods, rather than the verbose names.
>
>     ClassModel: Don't build empty constructors.  Allow classes that
>     don't have corresponding tags.  Don't output empty children maps.
>     Don't install anonymous classes in the tagmap.
>
> Tests:
>     smokecheck, ant runlztest
>
> Files:
> M      WEB-INF/lps/lfc/core/LzNode.lzs
> M      WEB-INF/lps/lfc/data/LzReplicationManager.lzs
> M      WEB-INF/lps/lfc/compiler/Class.lzs
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java
> M      
> WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema_Test.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ViewSchema.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> M      
> WEB-INF/lps/server/src/org/openlaszlo/compiler/ScriptElementCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
>
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20080606-ptw-1.tar
>