[Laszlo-dev] For Review: Change 20080604-maxcarlson-R Summary: Fix embedding inside iframes for IE

[Philip Romanik]

Approved!

>Change 20080604-maxcarlson-R by maxcarlson at Roboto on 2008-06-04
>15:26:55 PDT
>      in /Users/maxcarlson/openlaszlo/trunk-clean
>      for 
> <http://svn.openlaszlo.org/openlaszlo/trunk>http://svn.openlaszlo.org/openlaszlo/trunk
>
>Summary: Fix embedding inside iframes for IE
>
>Bugs Fixed: LPP-5365 - IE7 DHTML iframe embed doesn't respect 
>dimensions; canvas sized to browser window instead
>
>Technical Reviewer: promanik
>QA Reviewer: hminsky
>Doc Reviewer: (pending)
>
>Details: LzSprite.js - Clean up tests for width/height in root 
>sprite initialization.  Add document_size_compute_correct_height 
>quirk for IE 6.
>
>LzScreenKernel.js - Look in window instead of window.top for sizing.
>Support document_size_compute_correct_height quirk.  Remove cruft.
>
>Tests: Download the attached testcase from the bug report.  lpp-5365-
>ie-iframe-embed/main.jsp should show 100px for both embedded apps.
>lpp-5365-ie-iframe-embed/main.lzx?lzr=dhtml 
>lpp-5365-ie-iframe-embed/ main.lzx?lzr=dhtml&lzt=html show the same 
>size across IE 6/7 Safari and 
>Firefox.  my-apps/lpp-5365-ie-iframe-embed/main.lzx?
>lzr=dhtml&debug=true may show a slightly different size due to 
>scrollbars, but the red line is always at the bottom of the viewport 
>across IE 6/7 Safari and Firefox.
>
>Files:
>M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
>M      WEB-INF/lps/lfc/kernel/dhtml/LzScreenKernel.js
>
>Changeset: 
><http://svn.openlaszlo.org/openlaszlo/patches/20080604-maxcarlson-R.tar>http://svn.openlaszlo.org/openlaszlo/patches/20080604-maxcarlson-R.tar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080604/fa63d0c9/attachment.html