[Laszlo-dev] For Review: Change 20080604-ptw-8 Summary: Remove stray references to $refs

P T Withington ptw at pobox.com
Wed Jun 4 11:49:05 PDT 2008


Well, why didn't you fix the other swf while you were there? :)

I'll port your swf9 fix.  Thanks.

On 2008-06-04, at 14:48 EDT, André Bargull wrote:

> I thought you'd need to use "LzInitExpr" instead of "LzValueExpr",  
> at least everywhere else we use "LzInitExpr" to check initial  
> arguments.
> And you'll probably get a merge conflict in swf9, because I've  
> already done it there.
>
> Apart from that, approved.
>
>
> On 6/4/2008 8:22 PM, P T Withington wrote:
>> Change 20080604-ptw-8 by ptw at dueling-banjos.home on 2008-06-04  
>> 14:17:58 EDT
>>    in /Users/ptw/OpenLaszlo/ringding-clean
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Remove stray references to $refs
>>
>> Bugs Fixed:
>> Lpp-6043 'SWF: text-sprite looking for "$refs"'
>>
>> Technical Reviewer: a.bargull at intensis.de (pending)
>> QA Reviewer: hminsky (pending)
>>
>> Details:
>>    Don't know how these slipped through.  $refs no longer exists.  If
>>    you are trying to figure out if an attribute is being constrained,
>>    you look to see if the initial value is an LzValueExpr.
>>
>> Tests:
>>    smokecheck, ant lztest, inspection
>>
>> Files:
>> M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
>> M      WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
>>
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080604-ptw-8.tar
>>




More information about the Laszlo-dev mailing list