[Laszlo-dev] For Review: Change 20080603-laszlo-2 Summary: test-basetabs.lzx reference to undefined variable goldstyle
J Crowley
jcrowley at laszlosystems.com
Tue Jun 3 15:13:30 PDT 2008
Ahhh, thanks! Much more succinct. I'll change that before checking in.
Max Carlson wrote:
> To avoid warnings, you can use the idiom:
> this['isdefault']
>
> instead of:
> typeof this.isdefault != 'undefined'
>
> Otherwise, approved!
>
> J Crowley wrote:
>> Change 20080603-laszlo-2 by laszlo at T43-L3XEXMW on 2008-06-03 05:48:36
>> EDT
>> in /home/laszlo/src/svn/openlaszlo/trunk-3
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: test-basetabs.lzx reference to undefined variable goldstyle
>>
>> New Features:
>>
>> Bugs Fixed: LPP-3998 - test-basetabs.lzx reference to undefined
>> variable goldstyle
>>
>> Technical Reviewer: max at openlaszlo.org
>> QA Reviewer: a.bargull at intensis.de
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: Fixed the warning and the error that were showing up in
>> the Debugger when running the test file. (One was a needless
>> reference to a style class; the other was a reference to an
>> attribute without first checking whether the attribute was
>> defined.
>>
>> Tests: Run /test/components/lz/test-basetabs.lzx. It should behave
>> as expected, but without warning messages.
>>
>> Files:
>> M test/components/lz/test-basetabs.lzx
>> M lps/components/base/basecomponent.lzx
>>
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20080603-laszlo-2.tar
>>
>>
>
More information about the Laszlo-dev
mailing list