[Laszlo-dev] Fixing LPP-5644 (deprecating old setXXX methods)
P T Withington
ptw at laszlosystems.com
Wed Jul 9 11:00:19 PDT 2008
Ugh. Maybe we just let the things that were already made private stay
private until someone complains? We should still try to get a
complete list so we can generate compiler warnings.
On 2008-07-09, at 13:53 EDT, Philip Romanik wrote:
> I'll have a changeset out soon. What do we do about changes that
> were made for 4.1? For example, the setters in LzAnimation (such as
> setMotion) are marked private and do not show up in the 4.1 docs.
> They are deprecated, but they should show up in the docs, right?
>
>
>> Perhaps I was overly-aggressive in making them deprecated and
>> undocumented in one go. I think you are right. Let's make them
>> give a deprecation warning and leave them public for now.
>>
>> Can you either find the bug that talks about how LZX setters will
>> be specified or open another bug, and annotate that to say that we
>> need the compiler to deprecate any override of a 'setXXX' method
>> that is deprecated? Can you please keep a list of the methods you
>> find and are deprecating, so we can add those to the compiler's
>> deprecated methods list?
>>
>> On 2008-07-08, at 09:36 EDT, Philip Romanik wrote:
>>
>> > Hi Tucker,
>> >
>> > I'm working through the classes to deprecate the old setters. In
>> your
>> > pattern, the setXXX method is marked private. Won't this make them
>> > disappear from the docs?
>> >
>> > <http://jira.openlaszlo.org/jira/browse/LPP-5644>http://jira.openlaszlo.org/jira/browse/LPP-5644
>> >
>> > Shouldn't the comment look more like this?
>> >
>> > /**
>> > * @deprecated use setAttribute('setXXX', value) instead
>> > * @devnote remove after 4.2
>> > */
>> >
>> >
>> > Thanks!
>> >
>> > Phil
>> >
More information about the Laszlo-dev
mailing list