[Laszlo-dev] For Review: Change 20080703-hqm-j Summary: fix for SOLO POST bug

[Henry Minsky]

Yes, the  assertions in test/lfc/data/testpostmethodsolo.lzx test
ought to fail now.

                     var phone = dp.xpathQuery( '/echo/phone/text()');
                     assertEquals( "617-987-1234", phone );
                     var addr = dp.xpathQuery( '/echo/address/text()');
                     assertEquals( "67 Clyde Street", addr);



I'll try this in a clean branch.



On Thu, Jul 3, 2008 at 2:19 PM, Max Carlson <max at laszlosystems.com> wrote:
> If I run
> http://localhost:8080/trunk-clean/test/lfc/data/alldata.lzx?lzt=html with
> the patch applied to only the tests (no LFC changes) everything passes.
>  Shouldn't something fail?
>
> Henry Minsky wrote:
>>
>> Change 20080703-hqm-j by hqm at badtzmaru.home on 2008-07-03 13:15:44 EDT
>>    in /Users/hqm/openlaszlo/trunk4
>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: fix for SOLO POST bug
>>
>> New Features:
>>
>> Bugs Fixed: LPP-6586
>>
>> Technical Reviewer: max
>> QA Reviewer: pbr
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>>
>> + The code in LZHTTPDataProvider was sending all POST data through
>> LZHTTPLoader API, but SWF8 cannot really post raw data in SOLO mode,
>> it treats it like XML and will escape '&' and '<' chars.
>>
>> Fix is to add a flag, "hasquerydata", that is set as an option of the
>> LzHTTPLoader,
>> to give it a hint as to how to POST the data. If it is query data, send it
>> using the
>> Flash LoadVars.sendAndLoad API. If it is "raw", send it using the
>> XML.sendAndLoad (which
>> is better than nothing).
>>
>> + fixed regression test to more carefully look at echoed data from server
>>
>> Tests:
>>
>> test/lfc/data/alldata.lzx (swf, dhtml)
>> calendar (solo,proxied)
>> amazon (solo swf,proxied)
>>
>>
>> Files:
>> A      test/lfc/data/echobody.jsp
>> M      test/lfc/data/testgetmethod.lzx
>> M      test/lfc/data/testgetmethodsolo.lzx
>> M      test/lfc/data/testpostmethod.lzx
>> M      test/lfc/data/testsetheaders-solo.lzx
>> M      test/lfc/data/testpostmethodsolo.lzx
>> M      WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs
>> M      WEB-INF/lps/lfc/kernel/swf/LzLoadQueue.as
>> M      WEB-INF/lps/lfc/kernel/swf/LzHTTPLoader.as
>> M      WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
>> M      WEB-INF/lps/lfc/data/LzDataset.lzs
>>
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080703-hqm-j.tar
>
> --
> Regards,
> Max Carlson
> OpenLaszlo.org
>



-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com