[Laszlo-dev] For Review: Change 20080630-maxcarlson-j, Summary: Update lztestmanager and data test suite to run in swf9

[André Bargull]

There are a couple of changes to use "...rest" arguments, for instance:
> +    <method name="assertTrue" args="condition, ...assertion">
> +        if (assertion) assertion = assertion[0];
This means I can call "assertTrue" with unlimited arguments, e.g. 
"assertTrue('foo', 1, 2, 3, [], {}, 'hello')". Was this your intention? 
I guess not.
And for another reason, this change doesn't make any sense to me: 
"assertion" is always an Array, so the if-condition will always be true...

Did wanted to use this form?
> <method name="assertTrue" args="condition, assertion=undefined">
>     if (! semanticsTrue(condition)) {
>         this.fail(tformat(jsTrue(assertion) ? assertion : "True", 
> true, condition));
>     }
>     canvas.setAttribute('runTests', canvas.runTests + 1)
> </method>
And maybe you can use always directly this one:
> <method name="assertTrue" args="condition, assertion='True'">
>     if (! semanticsTrue(condition)) {
>         this.fail(tformat(assertion, true, condition));
>     }
>     canvas.setAttribute('runTests', canvas.runTests + 1)
> </method>


> Cool!  Approved.
>
> On 2008-06-30, at 22:28 EDT, Max Carlson wrote:
>
>   
>> > Change 20080630-maxcarlson-j by maxcarlson at Roboto on 2008-06-30  
>> > 19:13:47 PDT
>> >    in /Users/maxcarlson/openlaszlo/trunk-clean
>> >    for http://svn.openlaszlo.org/openlaszlo/trunk
>> >
>> > Summary: Update lztestmanager and data test suite to run in swf9
>> >
>> > Bugs Fixed: LPP-6574 - swf9: lztestmanager fails to run
>> >
>> > Technical Reviewer: promanik
>> > QA Reviewer: ptw
>> >
>> > Details: viewperf.lzx - Update to use lz.* when newing classes.
>> >
>> > datanode.lzx - Use local variable for test, provide arg to  
>> > LzDataElement constructor.
>> >
>> > datapath.lzx - Add missing attributes, rename bag argument var.
>> >
>> > alldata.lzs - Don't require the debugger (for swf9)
>> >
>> > xmlequals.lzx - Add missing args
>> >
>> > lztestmanager.lzx - Fix failure messages to be clearer
>> >
>> > lzunit.lzx - Move top-level function declarations to methods on  
>> > DebugObject, update optional args to use ... syntax.
>> >
>> > Tests: /test/lfc/data/alldata.lzx?lzr=swf9 now compiles, but fails  
>> > with runtime warnings.  This test runs as before in swf8 and dhtml.
>> >
>> > Files:
>> > M      test/lfc/perf/viewperf.lzx
>> > M      test/lfc/data/datanode.lzx
>> > M      test/lfc/data/datapath.lzx
>> > M      test/lfc/data/alldata.lzx
>> > M      lps/components/lztest/xmlequals.lzx
>> > M      lps/components/lztest/lztestmanager.lzx
>> > M      lps/components/lzunit/lzunit.lzx
>> >
>> > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080630-maxcarlson-j.tar
>>