[Laszlo-dev] [UPDATE] For Review: Change 20080125-ptw-x Summary: Yet another try at solving stretches vs. clickable

[P T Withington]

[RESENT:  Henry, could you review this in Max's stead?  I'd like to  
check this in so Pablo can test.]

[UPDATE: This 'fixes' Pablo's other test case, so that the scaling of  
subviews is not different depending on the clickability of the parent.]

Change 20080125-ptw-x by ptw at dueling-banjos.local on 2008-01-25  
15:41:02 EST
    in /Users/ptw/OpenLaszlo/ringding-2
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Yet another try at solving stretches vs. clickable

Bugs Fixed:
LPP-5372 'Mouse events available for first 100 pixels on a stretched  
view'

Technical Reviewer: max (pending)
QA Reviewer: pkang (pending)

Details:
    LzMakeLoadSprite: DON'T call updateResourceSize (which apparently
    papered over bugs in LzSprite, and now does the wrong thing).
    Don't inline parts of the code from LzSprite#set{Width,Height},
    which leads to skew; call them.

    LzSprite: Add an informative debugging name. Added a bunch of
    devnotes to document the secret inner workings of the Flash player
    that Adam apparently thougth were patently obvious.  Initialize
    resource{width,height}.  Make sure you have a clip to scale before
    you try to scale it.  Correct computation of scale for stretches
    when there is no resource supplied.  Correct the computation for
    scaling of button (clickable) to compensate for the parent clip
    being stretched.  Simplify computation of updateResourceSize.

    LzDebug: Make the movieclip debug printer more informative.  Print
    _width and _height of movieclip when inpsecting.

Tests:
    Test cases from LPP-5372, 4661 (original and one in comments), 3726

Files:
M      WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as
M      WEB-INF/lps/lfc/kernel/swf/LzSprite.as
M      WEB-INF/lps/lfc/debugger/platform/swf/LzDebug.as


Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080125-ptw-x.tar