[Laszlo-dev] For Review: Change 20080101-ben-w Summary: Fix misplaced comma in embedded examples

[Max Carlson]

Approved!

Benjamin Shine wrote:
> Change 20080101-ben-w by ben at slim.local on 2008-01-01 16:43:46 PST
>     in /Users/ben/src/svn/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Fix misplaced comma in embedded examples
> 
> New Features:
> 
> Bugs Fixed:
> 
> Technical Reviewer: (pending)
> QA Reviewer: max (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Max reported a bug due to a stray comma:
> http://labs.openlaszlo.org/trunk-nightly/docs/developers/tutorials/views-tutorial.html# 
> 
> 
> is failing now, due to a stray comma in the embedSWF calls, e.g.
>           Lz.swfEmbed({url: 'programs/views-tutorial-$1.lzx?lzt=swf', 
> id: 'd0e6065SWF', history: false, width: 500,
>       height: 300,
>       });
> 
> 
> This change moves around where we generate commas in the canvas 
> parameters when
> generating a live example. It now looks like this:
> 
>  Lz.swfEmbed({url: 'programs/views-tutorial-$1.lzx?lzt=swf', id: 
> 'd0e6061SWF', history: false
> , width: 500
> , height: 300});
> 
> Release Notes:
> 
> Details:
> 
> 
> Tests:
> build the doc
> inspect the source of tutorials/views-tutorial.html
> note good comma-ness.
> 
> Files:
> M      docs/src/xsl/common-html.xsl
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080101-ben-w.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org