[Laszlo-dev] For Review: Change 20080220-ptw-t Summary: Handle $style constraints in the unified argument processor

[André Bargull]

> [java] Warning: Assignment to free variable styleValue in 
> core/LzNode.lzs (513)
In LzNode#__LZstyleBindAttribute(..), "styleValue" should be "val", 
shouldn't it?


P T Withington wrote:
>  Change 20080220-ptw-t by ptw at dueling-banjos.local on 2008-02-20 19:36:51 
>  EST
>      in /Users/ptw/OpenLaszlo/ringding
>      for http://svn.openlaszlo.org/openlaszlo/trunk
>  
>  Summary: Handle $style constraints in the unified argument processor
>  
>  Bugs Fixed:
>  LPP-1587 'ECMA4: Compile LZX declarations as JS declarations' (partial)
>  LPP-4451 '$style cannot override other constraints'
>  LPP-1187 'overriding a literal with a constraint results in wrong value 
>  being assigned before constraint is resolved'
>  
>  
>  Technical Reviewer: max (pending)
>  QA Reviewer: mamye (pending)
>  
>  Details:
>      subclassing.lzx:  Uncomment test for lpp-4451, add inverse test,
>      annotate some assertions for easier debugging.
>  
>      LzFocus: Fix a type inconsistency that was triggering a warning in
>      smokecheck.
>  
>      LzNode: Delete old $style implementation, add styleBinder, add some
>      debug checks, permit constraints with no dependencies.
>  
>      LzDefs: Add style init expressions and style attribute binders.
>  
>      LzText: Teeny optimization.
>  
>      LzState: Simplify cloning.  Back out restoration of constraints
>      added in r8032 because it breaks dragstate and resizestate.
>  
>      LzFormatter: Fix pad to enforce max decimals bug revealed by
>      Firefox precision improvements in smokecheck.
>  
>      CSSHandler: Use style expressions instead of closures.
>  
>      ReferenceCollector: Correct comment
>  
>      NodeModel: Move style processing into unified attribute list, add
>      some asserts.
>  
>      lzunit.lzx: fail now will supply file/line for failed assertions
>      if backtracing is on.
>  
>  Tests:
>        test/style/constraints/subclassing.lzx
>        Test cases from LPP-1187, 4451
>        smokecheck, Amazon
>  
>  Files:
>  M      test/style/constraints/subclassing.lzx
>  M      WEB-INF/lps/lfc/services/LzFocus.lzs
>  M      WEB-INF/lps/lfc/core/LzNode.lzs
>  M      WEB-INF/lps/lfc/core/LzDefs.lzs
>  M      WEB-INF/lps/lfc/views/LzText.lzs
>  M      WEB-INF/lps/lfc/helpers/LzState.lzs
>  M      WEB-INF/lps/lfc/compiler/LzFormatter.lzs
>  M      WEB-INF/lps/server/src/org/openlaszlo/css/CSSHandler.java
>  M      WEB-INF/lps/server/src/org/openlaszlo/sc/ReferenceCollector.java
>  M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
>  M      lps/components/lzunit/lzunit.lzx
>  
>  Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080220-ptw-t.tar
>