[Laszlo-dev] For Review: Change 20071116-bargull-2 Summary: Add support for retrieving "nodeType" to LzDatapointer

[Max Carlson]

Approved!

André Bargull wrote:
> Change 20071116-bargull-2 by bargull at dell--p4--2-53 on 2007-11-16 00:27:11
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Add support for retrieving "nodeType" to LzDatapointer
> 
> New Features:
> 
> Bugs Fixed:
> LPP-5036 - Add getter-method for "nodeType" in LzDatapointer
> 
> Technical Reviewer: hminsky
> QA Reviewer: jcrowley
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> Almost every LzDataNode field/method can be retrieved through a 
> LzDatapointer-method (nodeName -> getNodeName, attrs -> 
> getNodeAttribute, etc.). But you cannot ask for the node-type of the 
> node the datapointer is pointing to through a LzDatapointer-method. That 
> means you need to access the "p"-field of a LzDatapointer directly to 
> get this info (dp.p.nodeType with dp instanceof LzDatapointer and dp.p 
> instanceof LzDataNode). This quite inconsistent compared to the rest of 
> the LzDatapointer-API and should be changed.
> This changeset enhances the LzDatapointer-API by introducing a new 
> method to handle this issue (LzDatapointer#getNodeType()).
> 
> 
> Tests:
> 
> Files:
> M WEB-INF/lps/lfc/data/LzDatapointer.lzs
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20071116-bargull-2.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org