[Laszlo-dev] For Review: Change 20080212-dda-g Summary: SWF9: fix global variables errantly created within 'default' class, fix debug temp files

[Donald Anderson]

Checked in.

On Feb 12, 2008, at 5:55 PM, Henry Minsky wrote:

> please check this in and I will test.
>
> On Tue, Feb 12, 2008 at 5:44 PM, Donald Anderson  
> <dda at ddanderson.com> wrote:
>> Change 20080212-dda-g by dda at lester.local on 2008-02-12 17:34:01 EST
>>     in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
>>     for http://svn.openlaszlo.org/openlaszlo/branches/devildog
>>
>> Summary:  SWF9: fix global variables errantly created within  
>> 'default'
>> class, fix debug temp files
>>
>> New Features:
>>
>> Bugs Fixed: LPP-5425
>>
>> Technical Reviewer: ptw (pending)
>> QA Reviewer: hminsky (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>>     This is actually two changes.
>>
>>     - A one line change to fix the problem reported by Henry in
>> LPP-5425.
>>       We now track that we are within a method correctly.  This makes
>>       the simple algorithm work: if we are not in a method and we are
>>       outside of a class definition (i.e. within the 'default  
>> class'),
>>       then vars are tracked as globals.
>>
>>     - To help debug this, needed to fix the creation of temp files
>>       that show the original source, processed source and AST.  A
>> previous
>>       change broke this - presumably these files were created in the
>>       'current directory', rather than in the /tmp/lzswf9/lzgen*
>>       directory.  Some cleanup done, some error checking added,
>>       in the name of making this code clearer and that error no
>> longer possible.
>>
>>
>> Tests:
>>
>> Files:
>> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
>> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080212-dda-g.tar
>>
>>
>>
>> --
>>
>> Don Anderson
>> Java/C/C++, Berkeley DB, systems consultant
>>
>> voice: 617-547-7881
>> email: dda at ddanderson.com
>> www: http://www.ddanderson.com
>>
>>
>>
>>
>>
>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com