[Laszlo-dev] For Review: Change 20080211-bargull-6 Summary: Cleanup for LzLibrary

[Donald Anderson]

Andre,

Not yet approved -
The public vars:  href, stage, onload
should have a description in the javadoc.
Everything else looks great (from doc viewpoint).
Thanks!

- Don

On Feb 11, 2008, at 6:47 PM, André Bargull wrote:

> Change 20080211-bargull-6 by bargull at dell--p4--2-53 on 2008-02-11  
> 22:46:58
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Cleanup for LzLibrary
>
> New Features:
>
> Bugs Fixed: LPP-5419, LPP-4227
>
> Technical Reviewer: hminsky
> QA Reviewer: (pending)
> Doc Reviewer: dda
>
> Documentation:
>
> Release Notes:
>
> Details:
> Only a couple of minor fixes and improvements:
> - added attributes/events to the LzLibrary classes (SWF,DHTML)
> - moved code from LzLibraryCleanup to LzLibrary  
> (LzLibrary#loadfinished(..)) (OOP-thingy)
> - added "loaded"/"loading" states for DHTML (were already supported  
> in SWF)
> - fixed: LzLibrary#destroy(..) did not destroy the library-sprite
> - removed old code in LzLibrary#unload() (SWF) ("delete  
> this.__LZmovieClipRef" is no longer necessary, was for OL3.x)
> - LzLibraryLoader#snippetLoaded(..) did not properly update  
> "loaded"/"loading" states, did not fire "ontimeout"-event, etc.
> - added docs for attributes/methods
>
>
> Tests:
>
> Files:
> M WEB-INF/lps/lfc/kernel/swf/LzLibrary.lzs
> M WEB-INF/lps/lfc/kernel/swf/LzLibraryLoader.lzs
> M WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js
> M WEB-INF/lps/lfc/kernel/LzLibraryCleanup.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080211-bargull-6.tar
>
>
>


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com