[Laszlo-dev] For Review: Change 20080207-hqm-k Summary:

[Henry Minsky]

On Thu, Feb 7, 2008 at 5:16 PM, Donald Anderson <dda at ddanderson.com> wrote:
> Comments:
>
>  1) For this url:
>
>             var url = "hello.lzx?
>  lzr=swf9&lz_load=false&lzt=eval&lz_script=" + encodeURIComponent(expr)
>  +"&lzbc=" +(new Date()).getTime();
>
>  If 'hello.lzx' is just a placeholder, maybe have a comment to that
>  effect.
>  If it is significant, then it shouldn't be hardwired...
>
>  2)  You checked in your private changes to lps.properties.

oops, I keep doing that by accident..


 But this
>  brings
>  up the larger issue - these properties are problematic for developers
>  and for our build machine.  Do we have a solution for these sort of
>  problems?


It would be possible to use an environment var I guess, like we do
with JAVA_HOME.
I actually don't like environment vars, they always seem to make
things more complicated,
but the JAVA_HOME has actually been working pretty well.



>  We need something that works for both unix and windows.  One way to
>  solve
>  is by creating a series of choices:
>
>     compiler.swf9.lib.builder=/usr/local/flex3/bin/compc,C:/
>  flex3,../../flex3/bin/compc
>
>  That gives choices for typical unix and Windows configs.  Anyone that
>  needed to
>  change that could edit this property -- but at least we could leave it
>  be for development,
>  and it makes our installation instructions easier -- fewer choices.
>
>
>  Otherwise - fine, approved.
>
>
>
>  On Feb 7, 2008, at 2:03 AM, Henry Minsky wrote:
>
>  > This is just an updated patch, to properly URI encode the
>  > expression  string when sent to the server
>  >
>  > Change 20080207-hqm-k by hqm at henry-minskys-macbook-pro.local on
>  > 2008-02-07 02:02:20 EST
>  >    in /Users/hqm/openlaszlo/devildog
>  >    for http://svn.openlaszlo.org/openlaszlo/branches/devildog
>  >
>  > Summary:  debug evaluator for swf9
>  >
>  > New Features:
>  >
>  > Bugs Fixed:
>  >
>  > Technical Reviewer: (pending)
>  > QA Reviewer: (pending)
>  > Doc Reviewer: (pending)
>  >
>  > Documentation:
>  >
>  > Release Notes:
>  >
>  > Details:
>  >
>  >
>  > Tests:
>  >
>  > Files:
>  > M      test/swf9/hello.lzx
>  > M      WEB-INF/lps/lfc/kernel/swf9/LFCApplication.as
>  > M      WEB-INF/lps/lfc/kernel/swf9/Library.lzs
>  > M      WEB-INF/lps/lfc/views/LaszloCanvas.js
>  > M      WEB-INF/lps/config/lps.properties
>  > M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
>  > M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
>  > M      WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/
>  > ResponderEVAL.java
>  > M      WEB-INF/lps/server/src/org/openlaszlo/compiler/
>  > CompilationEnvironment.java
>  > M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
>  >
>  > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080207-hqm-k.tar
>
>
>  --
>
>  Don Anderson
>  Java/C/C++, Berkeley DB, systems consultant
>
>  voice: 617-547-7881
>  email: dda at ddanderson.com
>  www: http://www.ddanderson.com
>
>
>
>
>



-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com