[Laszlo-dev] For Review: Change 20080205-dda-C Summary: Split SWF9Generator in preparation for mixin work

[P T Withington]

Approved.

On 2008-02-05, at 10:45 EST, Donald Anderson wrote:

> Change 20080205-dda-C by dda at lester.local on 2008-02-05 10:35:45 EST
>    in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
>    for http://svn.openlaszlo.org/openlaszlo/branches/devildog
>
> Summary: Split SWF9Generator in preparation for mixin work
>
> New Features:
>
> Bugs Fixed: LPP-5266 (partial)
>
> Technical Reviewer: ptw (pending)
> QA Reviewer: hminsky (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>    No functional changes!
>
>    SWF9Generator was too big, now split into SWF9Generator.java  
> containing
>    the node visitor, and SWF9External, containing everything to do  
> with
>    emitting code for the external compiler, compiling it, etc.
>
>    Added javadoc for most methods and classes.
>
>    A couple name changes:
>      flexCompile -> compileTranslationUnits
>      writeOutputFile -> writeFile (as the file is also input for the  
> compiler)
>      ExternalGeneratorError* -> ExternalCompilerError*
>
>    Removed an unused function and an unused method arg.
>
> Tests:
>    Henry's hello app
>    smoketest, lzpix, weather for both SWF8 and DHTML.
>
> Files:
> A      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080205-dda-C.tar
>
>
>
> --
>
> Don Anderson
> Java/C/C++, Berkeley DB, systems consultant
>
> voice: 617-547-7881
> email: dda at ddanderson.com
> www: http://www.ddanderson.com
>
>
>
>