[Laszlo-dev] For Review: Change 20080203-ptw-p Summary: Make handler reference functions be methods

[P T Withington]

On 2008-02-04, at 17:45 EST, Donald Anderson wrote:

> Approved, but a couple of points:
>
> NodeModel.java: line 982:
>  can body be null?  maybe  '      body = body_loc + body;'  needs to  
> go inside the if test?

Yup, found that in testing.  Thanks.

> NodeModel.java: line 1020:
>        String unique = "$" + parent_name + "_"  +  
> env.methodNameGenerator.next();
>  Do we restrict class names from not ending in underscore? (nit)

Not sure I care.  These are just internal names, don't need to be  
human readable.

> On Feb 3, 2008, at 3:50 PM, P T Withington wrote:
>
>> Change 20080203-ptw-p by ptw at dueling-banjos.local on 2008-02-03  
>> 11:50:17 EST
>>  in /Users/ptw/OpenLaszlo/ringding-2
>>  for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Make handler reference functions be methods
>>
>> Bugs Fixed:
>> LPP-1587 'ECMA4: Compile LZX declarations as JS  
>> declarations' (partial)
>>
>> Technical Reviewer: dda at openlaszlo.org (pending)
>> QA Reviewer: henry.minsky at gmail.com (pending)
>>
>> Details:
>>  LzNode: The 3rd element of a delegate is now the _name_ of the
>>  method that computes the sender, not a function.
>>
>>  NodeModel: Centralize the computation of delegates into a single
>>  subroutine shared by addHandlerElement, addHandlerFromAttribute,
>>  and (for backwards compatibility) addMethodElement.  Warn that
>>  defining handlers using the method event property is deprecated.
>>
>> Tests:
>>  smokecheck, amazon X swf, dhtml
>>
>> Files:
>> M      WEB-INF/lps/lfc/core/LzNode.lzs
>> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080203-ptw-p.tar
>
>
> --
>
> Don Anderson
> Java/C/C++, Berkeley DB, systems consultant
>
> voice: 617-547-7881
> email: dda at ddanderson.com
> www: http://www.ddanderson.com
>
>
>
>