[Laszlo-dev] For Review: Change 20081230-ptw-R Summary: Debug.xmlEscape needs to escape quotes too

[André Bargull]

Ah, I see. Thanks for the info!

On 12/30/2008 10:41 PM, P T Withington wrote:
> Ah whoops.  Wait, that seems to have gotten checked in with my previous 
> change?
> 
> You maybe didn't get it because you have 'modified' LzDebug.js while 
> reviewing my previous change.
> 
> Sorry, I should not make two intersecting changes like that.
> 
> On 2008-12-30, at 13:03EST, André Bargull wrote:
> 
>> Did you forget to include "LzDebug.js" to the changeset? At least to 
>> fix that bug, I needed to change this line in "makeObjectLink(..)" 
>> (dhtml):
>>> var tip = Debug.formatToString("Inspect %0.32#w", obj);
>> to:
>>> var tip = Debug.formatToString("Inspect %0.32#w", 
>>> obj).toString().toHTML();
>>
>> Otherwise approved!
>>
>>
>> On 12/30/2008 5:56 PM, P T Withington wrote:
>>> Change 20081230-ptw-R by ptw at dueling-banjos.home on 2008-12-30 
>>> 11:48:40 EST
>>>    in /Users/ptw/OpenLaszlo/trunk
>>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Debug.xmlEscape needs to escape quotes too
>>>
>>> Bugs Fixed:
>>> LPP-7538  DHTML: quotes are not masked
>>>
>>> Technical Reviewer: a.bargull at intensis.de (pending)
>>> QA Reviewer: hminsky (pending)
>>>
>>> Details:
>>>    Use the improved escape when computing the DHTML objectLink tool tip
>>>
>>> Tests:
>>>    Test case from bug report
>>>
>>> Files:
>>> M      WEB-INF/lps/lfc/compiler/LzMessage.lzs
>>>
>>> Changeset: 
>>> http://svn.openlaszlo.org/openlaszlo/patches/20081230-ptw-R.tar
>>>
>>
> 
>