[Laszlo-dev] [Laszlo-checkins] r12138 - openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9

[Max Carlson]

I'm not sure this is right - I think it _should_ apply the color 
transform.  Perhaps the reason it looks different in swf8 and swf9 is 
because swf8 uses a separate movieclip for the bgcolor, thereby avoiding 
having the color transform applied...

pbr at openlaszlo.org wrote:
> Author: pbr
> Date: 2008-12-16 09:19:38 -0800 (Tue, 16 Dec 2008)
> New Revision: 12138
> 
> Modified:
>    openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> Log:
> Change 20081216-Philip-4 by Philip at Philip-DC on 2008-12-16 11:54:26 EST
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Make setColor a nop in swf9
> 
> New Features:
> 
> Bugs Fixed: LPP-7481
> 
> Technical Reviewer: hqm
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> Removed the definition of setColor/getColor in LzSprite.as. This is for text drawing and it was setting the ColorTransform object (from r11271).
> 
> The test app has an issue in swf8 that has been around since lps3. I created LPP-7490 to track this.
> 
>    
> 
> Tests:
> Testcase in LPP-7481 works as expected in swf9.
> 
> <canvas width="100%" height="100%"> 
> <view width="100%" height="100%" bgcolor="0x000000" fgcolor="0xffffff"> 
> <text text="a test text" bgcolor="0x0000ff"/> 
> </view> 
> </canvas> 
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081216-Philip-4.tar
> 
> 
> Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
> ===================================================================
> --- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzSprite.as	2008-12-16 17:01:45 UTC (rev 12137)
> +++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzSprite.as	2008-12-16 17:19:38 UTC (rev 12138)
> @@ -852,21 +852,18 @@
>            o Can be a number (0xff00ff):void or a string ('#ff00ff'):void 
>        */
>        public function setColor( color:* ):void {
> -          if (color is String) {
> -              color = LzColorUtils.hextoint(color);
> -          }
> -          var nc:ColorTransform = new ColorTransform();
> -          nc.color = color;
> -          nc.alphaMultiplier = 1.0;
> -          this.transform.colorTransform = nc;
> +          // Only applicable for text
>        }
>  
> +      /** Returns the foreground color of the sprite. This isn't known so
> +          0 is returned.
> +      */
>        public function getColor  (){
> -          return this.transform.colorTransform.color;
> +          // Only applicable for text
> +          return 0;
>        }
>  
>  
> -
>        /**
>         * Returns an object that represents the color transformation currently applied
>         * to the view. The color transform object has the following possible keys
> 
> 
> _______________________________________________
> Laszlo-checkins mailing list
> Laszlo-checkins at openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins

-- 
Regards,
Max Carlson
OpenLaszlo.org