[Laszlo-dev] For Review: Change 20081212-ptw-W Summary: Remove magic from <text>/text setter

[André Bargull]

Please exclude the music-example and update:
DHTML:
- LzInputTextSprite.prototype.getTextfieldHeight (same changes as for 
LzTextSprite.prototype.getTextfieldHeight)
SWF8:
- LzInputTextSprite.prototype.__initTextProperties (see the assignment 
to `this.text`)

Otherwise approved!


On 12/13/2008 5:38 PM, P T Withington wrote:
> Change 20081212-ptw-W by ptw at dueling-banjos.home on 2008-12-12 
> 18:01:24 EST
>     in /Users/ptw/OpenLaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Remove magic from <text>/text setter
>
> Bugs Fixed:
> LPP-4740 Testing for null and undefined values for LzText#setText(..) 
> is too naive
> LPP-7454 Add <text>/addFormat (that appends rather than replaces)
>
> Technical Reviewer: a.bargull at intensis.de (pending)
> QA Reviewer: max (pending)
> Doc Reviewer: lou at louiorio.com (pending)
>
> Details:
>     Lz{Input,}TextSprite.*: Removed magic that tried to determine if
>     the text had been set to null but turned into the string "null".
>     Sprites should not have to worry about non-string values, the text
>     should always be a string and they should just deal with it.
>
>     LzText: If a non-String value is set into text, convert it to a
>     string using String().  Update the documentation:  if you want
>     your <text> to be empty, set it to the empty string.  Also updated
>     some read-only/deprecations noticed in passing.
>
> Tests:
>     smokecheck X {swf8,dhtml,swf9}, testcase from bug (updated to not
>     incur warnings or errors) X {swf8,dhtml,swf9}
>
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
> M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
> M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
> M      WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
> M      WEB-INF/lps/lfc/views/LzText.lzs
> M      examples/music/music.lzx
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20081212-ptw-W.tar
>