[Laszlo-dev] For Review: Change 20081206-bargull-jOa Summary: datapath defined on class crashes app

[André Bargull]

On 12/6/2008 11:38 PM, P T Withington wrote:
> It seems to me that your __LZgetInstanceAttr is working around my note 
> "[2008-12-01 ptw]  I did not use LzNode/__LZhasConstraint here...".  If 
> the constructor really wanted to see all the attrs, it could just look 
> in the initargs list, couldn't it?  And it could use __LZhasConstraint 
> to see if there was a constraint.  Do we really need __LZgetInstanceAttr?

Yes, it was added to fix the bug you've noted. (It was a regression from 
LPS3, in which _instanceAttrs had different semantic.)
Neither the initargs list nor __LZhasConstraint will help here, because 
the replication manager doesn't look at its own attributes, but at the 
attributes of the clone or more specifically at the attributes of the 
view which will be cloned.


> 
> Also, you should probably put a comment in mergeAttributes regarding 
> _ignoreAttribute.  I think that the clone operation is possibly the only 
> place that actually needs to use _ignoreAttribute any more.  Everywhere 
> else, now that inheritedHash is flattened, you can just delete an arg, 
> but in cloning you are saving away a half-processed arglist that will be 
> _re_-merged with the parent class args, so you need to have a way to 
> memoize the deletion.

Ok, I'll add a note to mergeAttributes.

> 
> On 2008-12-06, at 13:40EST, André Bargull wrote:
> 
>> Change 20081206-bargull-jOa by bargull at dell--p4--2-53 on 2008-12-06 
>> 19:15:07
>> in /home/Admin/src/svn/openlaszlo/trunk
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: datapath defined on class crashes app
>>
>> New Features:
>>
>> Bugs Fixed: LPP-7420, LPP-7428
>>
>> Technical Reviewer: hqm
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>> LPP-7428:
>> Set "cloneAttrs.datapath" to ignoreAttribute to override any datapath 
>> declared on class.
>> (This involves how ignoreAttribute is handled in LzNode#mergeAttributes.)
>>
>> LPP-7420:
>> You can't rely solely on "_instanceAttrs" to find constrained 
>> datapaths, you need to look up constructor.attributes, too.
>> Therefore I've added "__LZgetInstanceAttr", which checks both.
>>
>>
>> Tests:
>> attached at bugreports, tested in swf8/swf9
>>
>> Files:
>> M WEB-INF/lps/lfc/data/LzReplicationManager.lzs
>>
>> Changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20081206-bargull-jOa.tar
>>
>>
> 
>