[Laszlo-dev] For Review: Change 20081130-bargull-VjZ Summary: fix global color issues

P T Withington ptw at pobox.com
Wed Dec 3 12:29:05 PST 2008


That seems like a bug.

Well, this works, but I'm not sure you should have to say all that:

   <myview width="50" height="50" oninit="this.acceptAttribute('bgc',  
'color', 'red')" />

Seems to me we would like any color-typed attribute to have the same  
behavior as bgcolor.

On 2008-12-03, at 14:44EST, André Bargull wrote:

> Not really, only for "bgcolor".
>
>
> <canvas debug="true" >
> <class name="myview" extends="view" bgcolor="${this.bgc &amp;  
> 0xff0000}" >
>  <attribute name="bgc" value="#000000" type="color" />
> </class>
>
> <myview width="50" height="50" oninit="this.setAttribute('bgc',  
> 'red')" />
> </canvas>
>
> On 12/3/2008 8:29 PM, P T Withington wrote:
>> Just FYI, if an attribute is declared as type="color", then you can  
>> use color names, but you have to pass the name as a String, so you  
>> could pass, say 'white' as the value to setAttribute, instead of  
>> 0xFFFFFF, if that would be more in the spirit of the code.  All the  
>> css3 color names are available.
>> On 2008-11-30, at 09:41EST, André Bargull wrote:
>>> Change 20081130-bargull-VjZ by bargull at dell--p4--2-53 on  
>>> 2008-11-30 15:33:00
>>> in /home/Admin/src/svn/openlaszlo/trunk
>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: fix global color issues
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-7412
>>>
>>> Technical Reviewer: (pending)
>>> QA Reviewer: (pending)
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details:
>>> - use numeric constants instead of global values like "red"
>>> - changed "tint" and "fontcolor" type to "color" in  
>>> stylishbutton.lzx
>>>
>>>
>>> Tests:
>>>
>>>
>>> Files:
>>> M lps/components/incubator/roundrectbutton.lzx
>>> M lps/components/incubator/stylishbutton.lzx
>>> M lps/components/incubator/test/opttree/treenode.lzx
>>> M lps/components/incubator/rich-text/linkdialog.lzx
>>> M lps/components/base/baselist.lzx
>>>
>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081130-bargull-VjZ.tar
>>>
>>>
>




More information about the Laszlo-dev mailing list