[Laszlo-dev] For Review: 20081201-laszlo-0 Summary: Datapointer.deleteNode() should check previous sibling if next sibling doesn't exist, Databinding example 23 exhibits odd behavior

André Bargull andre.bargull at udo.edu
Mon Dec 1 06:21:29 PST 2008


The example (and its documentation) needs to be changed, or else it'll 
suggest a bit nonsense to the reader:
In fact, the "setXPath(..)"-call can be removed completely, you just 
need to set the rerunxpath-attribute to `false`. And then you also need 
to adjust this sentence from the doc:
> The solution is to reset the datapath's XPath to the proper value by calling the setXPath() method: 


Otherwise approved!



On 12/1/2008 11:57 AM, J Crowley wrote:
> Change 20081201-laszlo-0 by laszlo at T43-L3XEXMW on 2008-12-01 05:36:10 EST
>    in /home/laszlo/src/svn/openlaszlo/trunk-grayfox
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Datapointer.deleteNode() should check previous sibling if next 
> sibling doesn't exist
>    Databinding example 23 exhibits odd behavior
> 
> New Features:
> 
> Bugs Fixed: LPP-7416 - Datapointer.deleteNode() should check previous 
> sibling if next sibling doesn't exist
>            LPP-7220 - Databinding example 23 exhibits odd behavior
> 
> Technical Reviewer: ptw
> QA Reviewer: andre.bargull at udo.edu
> Doc Reviewer: lou at louiorio.com
> 
> Documentation:
> 
> Release Notes:
> 
> Details: LPP-7416 - Applied Andre's fix suggestion.
>         LPP-7220 - Changed rerunxpath to false to get the
>            example to function appropriately (with LPP-7416
>            fixed).
> 
> Tests: Run databinding-$23.lzx.  Click "Next" until you
>    reach the end of the list.  Click "Delete".  You
>    should now move to the previous node when the current
>    one is deleted, if there is no next node.  Compare to
>    an unmodified version, where the data references an
>    invalid node and then subsequently returns all nodes.
> 
> Files:
> M      WEB-INF/lps/lfc/data/LzDatapointer.lzs
> M      docs/src/developers/programs/databinding-$23.lzx
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20081201-laszlo-0.tar
> 
> 
> 



More information about the Laszlo-dev mailing list