[Laszlo-dev] [Laszlo-checkins] r10830 - in openlaszlo/trunk: WEB-INF/lps/lfc/kernel/swf/dojo lps/includes/source

[Amy Muntz]

Given that this is just the first beta, I think you should check it in. 
We have to do another build tonight anyway.
Please do.
Thanks,
Amy


On Thu, Aug 28, 2008 at  8:18 PM , Max Carlson wrote:

> Mamye asked me not to check this in.  Personally, I think it should go 
> as part of 4.2, because anyone running swf9 in IE will get the error.
>
> P T Withington wrote:
>> You'll need to integrate this to branches/4.2beta.  Then one of us 
>> ought to kick off a build, since Mamye is on the road.
>>
>> On 2008-08-28, at 17:18EDT, max at openlaszlo.org wrote:
>>
>>> Author: max
>>> Date: 2008-08-28 14:18:05 -0700 (Thu, 28 Aug 2008)
>>> New Revision: 10830
>>>
>>> Modified:
>>>   openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/dojo/Library.lzs
>>>   openlaszlo/trunk/lps/includes/source/lzhistory.js
>>> Log:
>>> Change 20080828-maxcarlson-o by maxcarlson at Bank on 2008-08-28 
>>> 13:54:21 PDT
>>>    in /Users/maxcarlson/openlaszlo/trunk-clean
>>>    for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: Fix runtime errors in IE with swf9
>>>
>>> Bugs Fixed: LPP-6906 - IE gets runtime error in swf9 due to legacy 
>>> history mechanism code
>>>
>>> Technical Reviewer: hminsky
>>> QA Reviewer: promanik
>>>
>>> Details: Library.lzs - Comment out unneeded global declaration (not 
>>> sure if you can even do this in swf9)
>>>
>>> lzhistory.js - Don't test for callbackid - legacy of the old swf6/7 
>>> JS comm system.
>>>
>>> Tests: Loading lzpix in swf9 on IE 7 no longer fails.
>>>
>>>
>>>
>>> Modified: 
>>> openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/dojo/Library.lzs
>>> ===================================================================
>>> --- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/dojo/Library.lzs 
>>> 2008-08-28 21:00:54 UTC (rev 10829)
>>> +++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/dojo/Library.lzs 
>>> 2008-08-28 21:18:05 UTC (rev 10830)
>>> @@ -10,5 +10,5 @@
>>>     #include "kernel/swf/dojo/flash6/DojoExternalInterface.as"
>>> }
>>>
>>> -// required for GetVariable to not fail in IE/ActiveX
>>> -_root._callbackID = null;
>>> +// required for GetVariable to not fail in IE/ActiveX for swf6/8 - 
>>> see lzhistory.js
>>> +//_root._callbackID = null;
>>>
>>> Modified: openlaszlo/trunk/lps/includes/source/lzhistory.js
>>> ===================================================================
>>> --- openlaszlo/trunk/lps/includes/source/lzhistory.js    2008-08-28 
>>> 21:00:54 UTC (rev 10829)
>>> +++ openlaszlo/trunk/lps/includes/source/lzhistory.js    2008-08-28 
>>> 21:18:05 UTC (rev 10830)
>>> @@ -224,14 +224,19 @@
>>>         if (app && app.loaded && app.runtime == 'swf') {
>>>             var p = app._getSWFDiv();
>>>             if (p) {
>>> +                /*
>>> +                // for swf6/7 communications, to prevent trampling 
>>> callbacks.
>>>                 //console.log('__setFlash', h, app, id, p);
>>>                 var cid = p.GetVariable("_callbackID") + '';
>>>                 if (cid == 'null') {
>>> -                    lz.embed[id]._lasthash = 
>>> app.callMethod("lz.History.receiveHistory(" + h + ")");
>>> +                */
>>> +                lz.embed[id]._lasthash = 
>>> app.callMethod("lz.History.receiveHistory(" + h + ")");
>>> +                /*
>>>                 } else {
>>>                     setTimeout('lz.embed.history.__setFlash(' + h + 
>>> ',"' + id + '")', 10);
>>>                 //alert('busy');
>>>                 }
>>> +                */
>>>             }
>>>         }
>>>     }
>>>
>>>
>>> _______________________________________________
>>> Laszlo-checkins mailing list
>>> Laszlo-checkins at openlaszlo.org
>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
>>
>
> -- 
> Regards,
> Max Carlson
> OpenLaszlo.org