[Laszlo-dev] For Review: Change 20080823-bargull-ZMZ Summary: add RegExp support to swf8

[André Bargull]

While doing a last pre-commit check, I've found two bugs. I'll send a 
new changeset.

On 8/26/2008 1:32 AM, Max Carlson wrote:
> Sounds good!
> 
> André Bargull wrote:
>> Yes, the 'undefined pattern in AS3' thread is about this compiler 
>> error. Therefore I've changed the variable typing from "Object" to 
>> "*", so compilation proceeds successfully for swf9. With that change, 
>> I'll commit the whole changeset, ok?
>>
>>
>> On 8/26/2008 12:58 AM, Max Carlson wrote:
>>> Not approved.  This change works well for swf8 and dhtml, but fails 
>>> to compile for swf9.
>>>
>>> If I conditionally exclude LzCache from swf9, the build completes:
>>>
>>> if ($swf9) {
>>> } else {
>>> #include "helpers/LzCache.lzs"
>>> }
>>>
>>> I suspect you already know about this issue, based on the recent 
>>> 'undefined pattern in AS3' thread.
>>>
>>> If you want to disable LzCache in swf9 go ahead and check it in - it 
>>> adds some really nice functionality for swf8 and dhtml.  We can add 
>>> swf9 parity later!
>>>
>>> André Bargull wrote:
>>>> Change 20080823-bargull-ZMZ by bargull at dell--p4--2-53 on 2008-08-23 
>>>> 21:13:55
>>>> in /home/Admin/src/svn/openlaszlo/trunk
>>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>>
>>>> Summary: add RegExp support to swf8
>>>>
>>>> New Features: LPP-1584, LPP-6546
>>>>
>>>> Bugs Fixed:
>>>>
>>>> Technical Reviewer: max
>>>> QA Reviewer: rbitter
>>>> Doc Reviewer: (pending)
>>>>
>>>> Documentation:
>>>>
>>>> Release Notes:
>>>>
>>>> Details:
>>>> Adds support for RegExp to swf8 by using Flash's ExternalInterface 
>>>> to proxy regular expressions to the browser.
>>>> Also defines "String.prototype.match", "String.prototype.replace" 
>>>> and "String.prototype.search".
>>>> Internally a simple cache is used to reuse compiled RegExps on the 
>>>> browser-part (LzCache).
>>>> Some extra work was necessary to workaround ExternalInterface bugs, 
>>>> this is documented in "LzRegExp.lzs".
>>>>
>>>>
>>>> Tests:
>>>> buildlfc swf8 + cd lps/includes/source; ant clean build
>>>> test/regexp.lzx
>>>>
>>>> Files:
>>>> A WEB-INF/lps/lfc/kernel/swf/LzRegExp.lzs
>>>> M WEB-INF/lps/lfc/kernel/swf/Library.lzs
>>>> A WEB-INF/lps/lfc/helpers/LzCache.lzs
>>>> M WEB-INF/lps/lfc/helpers/Library.lzs
>>>> A lps/includes/source/regexp.js
>>>> M lps/includes/source/embed-library.lzs
>>>> A test/regexp.lzx
>>>>
>>>> Changeset: 
>>>> http://svn.openlaszlo.org/openlaszlo/patches/20080823-bargull-ZMZ.tar
>>>>
>>>>
>>>
>>
>