[Laszlo-dev] For Review: Change 20080825-hqm-A Summary: fix for debug eval feature in swf9

[Donald Anderson]

Approved.

On Aug 25, 2008, at 2:18 PM, Henry Minsky wrote:

> Change 20080825-hqm-A by hqm at badtzmaru.home on 2008-08-25 14:12:17 EDT
>    in /Users/hqm/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary:  fix for debug eval feature in swf9
>
> New Features:
>
> Bugs Fixed:
>
> Technical Reviewer: dda
> QA Reviewer: pbr
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> Recently LFCApplication was given a new "sprite" arg to its  
> constructor.
> The code for DebugEvaluate uses the same code paths in swf9generator  
> for
> compiling a "debug eval" app, which generates a "sprite" arg in its  
> constructor now,
> but the app is executed as a  standalone movie that gets loaded at  
> runtime, and thus is not called
> with any arg to its constructor.
>
> I made the code in parsetreeprinter make the sprite arg optional,  
> which covers both cases now.
>
> There might be a better way to fix this, to make the debug eval  
> code  path less intertwined with the main
> app compilation.
>
>
>
> Tests:
> run an app which has the debugger displayed
>
> <canvas oninit="Debug.write('foo')"/>
>
> and then type an expression into the eval input field and see
> if it prints the result
>
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9External.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> SWF9ParseTreePrinter.java
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080825-hqm-A.tar


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080825/42077e82/attachment.html