[Laszlo-dev] For Review: Change 20080807-dda-O Summary: Allow DHTML versions of tutorial examples to build and (start to) run

[Donald Anderson]

Change 20080807-dda-O by dda at lester.local on 2008-08-07 10:05:13 EDT
     in /Users/dda/laszlo/src/svn/openlaszlo/trunk-doc5
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Allow DHTML versions of tutorial examples to build and (start  
to) run

New Features:

Bugs Fixed: LPP-3887 (compiling dguide for both runtimes crashes  
firefox)

Technical Reviewer: max (pending)
QA Reviewer: (pending)
Doc Reviewer: liorio (pending)

Documentation:

Release Notes:

Details:
     After enabling DHTML as indicated in LPP-3887, discovered that  
some of the code was stale and needed
     some fixes.  After fixing, the 'basics' page runs correctly in  
DHTML
     without crashing Firefox either on MacOSX/Firefox or Windows  
(parallels)/Firefox
     or MacOSX/Safari.  Other pages probably need some debugging for  
DHTML,
     for example, docs/developers/tutorials/calculator.html doesn't  
show much at all
     in the examples for DHTML (tried in MacOSX/Firefox) but doesn't  
crash firefox
     either.  Presumably other pages may produce mixed results, but at  
least
     DHTML is now possible, and examples can be tried/debugged/fixed  
by directly
     editting the example code.

     Nature of the fixes:

     some canvas parameters - height and width are being passed
     as unquoted:    height: 100   vs.  height: '100'
     The quoted representation seems to be required for DHTML, but
     the unquoted args are pervasive, rather than change them all,
     I fixed the XSL 'rewrite' of the programs to add quotes when  
necessary.

     There was an extra stray comma in the embed parameter list that  
is now removed.

     For the first two examples on the basics page, the implementation  
did not
     match what was shown as source (height was 150 rather than 100 in  
the source).
     Standardized these on 100, and in doing so, discovered a lot of  
duplication in
     laszlo_basics.dbk - the code for each example is listed 3 times  
(!),
     though two of these are commented, and most of the actual code  
used is in a different
     file entirely (e.g. docs/src/developers/tutorials/programs/ 
laszlo_basics-$1.lzx).
     Left the commented code, it is possible it is/was used to help  
generate the
     actual code files?  Canvas args are handled specially it seems.

     The parts that need to be commented/uncommented for DHTML to work  
are now consistently
     marked with <?ignore  (one spot was //commented in Javascript  
before).

     A couple errors in docbook.css have been corrected.

     In this work, I never saw a crash of Firefox (problem originally  
reported),
     so that error seems to be due to older DHTML code or older  
versions of Firefox.

Tests:
     Examined:
        http://localhost:8080/trunk/docs/developers/tutorials/laszlo_basics.html

     Regression: smokecheck SWF8, DHTML + hello SWF9

Files:
M      docs/src/xsl/common-html.xsl
M      docs/src/developers/tutorials/laszlo_basics.dbk
M      docs/src/developers/tutorials/programs/laszlo_basics-$1.lzx
M      docs/src/developers/tutorials/programs/laszlo_basics-$2.lzx
M      docs/includes/docbook.css

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080807-dda-O.tar



--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080807/4f0bb812/attachment.html