[Laszlo-dev] For Review: Change 20080804-Philip-4. Summary: Fix (a in b) in LFC and components

[P T Withington]

Not approved yet:

You will also have to fix the cases where the idiom was to `delete` an  
attribute (e.g., basescrollbar) as you are not permitted to delete a  
fixture.  The `delete` idiom should be replaced with setting the  
attribute to `null` (or whatever the initial sentinel value was).

If you make this fix, then approved.

---

Also, please file a Jira bug against the LZX (Tag) compiler that:

> <attribute name="toolbar"  />

e.g., attributes without initial values, must still be created as  
fixtures in the user class.  The previous optimization of omitting  
attributes without an initial value is no longer valid.

On 2008-08-04, at 17:38EDT, Philip Romanik wrote:

> Change 20080804-Philip-4 by Philip at Philip-DC on 2008-08-04 13:42:23  
> EDT
>    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix (a in b) in LFC and components
>
> New Features:
>
> Bugs Fixed: LPP-6670 (partial)
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> Most uses of 'in' are correct as they refer to keys in hashes. I  
> removed 'in' in the LFC and components, with the exception of  
> debugging which will be a separate changeset.
>
> In most cases the fix was to make sure the class defines the value  
> and then remove the 'in' check.
>
> /data/LzHTTPDataProvider.lzs - secure is always defined
>
> /views/LaszloCanvas.lzs - default version to null and remove check
>
> /views/LaszloView.lzs - onremovesubview exists, removed check
>
> /base/basescrollbar.lzx - Added attributes to remove 'in' checks
>
> /charts/common/valueregion.lzx - Moved stretches into an attribute
>
> /lz/tabs.lzx  background check not necessary.
>
> /utils/replicator/replicator.lzx - All views (and all nodes) have  
> setSelected() method.
>
> /incubator/rich-test/richtexteditarea.lzx - default toolbar and  
> linkpanel to null and removed checks
>
> /incubator/rich-text/test/formatfontsize.lzx - same as above
>
>
> Tests:
> lzpix in swf/dhtml (problems in swf8: see lpp-6753)
> smoketest in swf/dhtml
> component_sampler.lzx in swf/dhtml/swf9
>
> Files:
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
> M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
> M      WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
> M      lps/components/charts/styles/chartstyle.lzx
> M      lps/components/charts/common/valueregion.lzx
> M      lps/components/lz/tabs.lzx
> M      lps/components/incubator/rich-text/test/formatfontsize.lzx
> M      lps/components/incubator/rich-text/richtexteditarea.lzx
> M      lps/components/utils/replicator/replicator.lzx
> M      lps/components/base/basescrollbar.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080804-Philip-4.tar
>