[Laszlo-dev] For Review: Change 20080416-ptw-o Summary: Fix <script> semantics in swf9

[Donald Anderson]

Approved!

On Apr 16, 2008, at 4:06 PM, P T Withington wrote:

> Change 20080416-ptw-o by ptw at dueling-banjos.local on 2008-04-16  
> 15:57:25 EDT
>    in /Users/ptw/OpenLaszlo/ringding
>    for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix <script> semantics in swf9
>
> Bugs Fixed:
> LPP-5725 'In swf9, script when="immediate" should be included before  
> any top-level methods'
>
> Technical Reviewer: dda at ddanderson.com (pending)
> QA Reviewer: max (pending)
>
> Details:
>    JavascriptGenerator: Note vars from script blocks as globals.
>
>    swf9Generator, CommonGenerator: addGlobalVar promoted to  
> CommonGenerator
>
>    ScriptCompiler, ClassCompiler, ViewCompiler, ElementCompiler,
>    InterfaceCompiler, ScriptElementCompiler: remove stale
>    'emitClassDecl' experiment accidentally merged from devildog
>
>    lztestmanager: Classes need to be dynamic so they can add
>    properties to themselves.
>
> Tests:
>    ant lztest runlzunit
>
>    [ptw at dueling-banjos lztest 15:56:40]$ /usr/local/flex_sdk_3/bin/ 
> fdb lztest-animator.lzr=swf9.swf
>    ...
>    [trace] idle timer period =  14 msecs
>    [trace] dummy LzBrowser getInitArg declared in core/dummyclasses.js
>    [trace] LzScreenKernel event [object Object]
>    [trace] dummy LzBrowser getInitArg declared in core/dummyclasses.js
>    [trace] lzcancas __LZcallinit isinited false
>    [trace] Passed all suites.
>      C-c C-c[ptw at dueling-banjos lztest 15:57:17]$
>
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> JavascriptGenerator.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/ScriptCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ClassCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ViewCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ElementCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> InterfaceCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ScriptElementCompiler.java
> M      lps/components/lztest/lztestmanager.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080416-ptw-o.tar


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com