[Laszlo-dev] [JIRA] Updated: (LPP-5773) id's do not work in swf9

Mon Apr 14 21:09:06 PDT 2008

Hm...  That doesn't look so good.

I made it so datasets no longer define a global alias to themselves,  
since they are already children of canvas _and_ in canvas.datasets.  I  
wonder who is making these global references.  Guess I have to turn on  
backtracing...

On 2008-04-14, at 21:14 EDT, Henry Minsky wrote:
> I get these warnings from the Amazon app in swf debug mode. However  
> the app
> actually
> seem to be working as usual. It looks like  for the first few, each
> <dataset> tag which declares a  dataset
> is generating a warning.
>
> making canvas sprite «kernel/swf/LzSprite.as#15/16#1#0| LzSprite for  
> This is
> the canvas [0.00 x 0.00]*[1.00 0 0.00, 0 1.00 0.00, 0 0 1]»
> ERROR @amazon.lzx#18: reference to undefined variable 'dsRecommend'
> ERROR @amazon.lzx#21: reference to undefined variable 'dsKeyword'
> ERROR @amazon.lzx#37: reference to undefined variable 'dsAsin'
> ERROR @amazon.lzx#118: reference to undefined variable 'main'
> ERROR @amazon.lzx#120: reference to undefined variable  
> 'searchResultsArea'
> ERROR @amazon.lzx#125: reference to undefined variable 'cdlist'
> ERROR @amazon.lzx#133: reference to undefined variable 'searchLoader'
> ERROR @amazon.lzx#168: reference to undefined variable 'recommend'
> ERROR @amazon.lzx#180: reference to undefined variable 'cdinfo'
> ERROR @amazon.lzx#198: reference to undefined variable 'cover'
> ERROR @amazon.lzx#233: reference to undefined variable 'pokeme'
> ERROR @amazon.lzx#252: reference to undefined variable  
> 'CustomerReviewsTab'
> ERROR @amazon.lzx#295: reference to undefined variable
> 'customerReviewsContainer'
> ERROR @amazon.lzx#185: reference to undefined variable 'infoLoader'
> ERROR @amazon.lzx#368: reference to undefined variable 'cart'
> ERROR @amazon.lzx#390: reference to undefined variable 'wish'
> ERROR @amazon.lzx#390: reference to undefined variable 'checkout'
> ERROR @amazon.lzx#426: reference to undefined variable  
> 'shipmentSelection'
> ERROR @amazon.lzx#489: reference to undefined variable 'dragger'
> ERROR @amazon.lzx#516: reference to undefined variable 'dragsmall'
> ERROR @debugger/debugger.lzx#111: reference to undefined variable
> '_dbg_cmd_eval'
> ERROR @debugger/debugger.lzx#238: reference to undefined variable
> '_dbg_cmd_hist_prev'
> ERROR @debugge
>
>
> On Mon, Apr 14, 2008 at 8:33 PM, P T Withington (JIRA) <
> jira at laszlosystems.com> wrote:
>
>>
>>    [
>> http://www.openlaszlo.org/jira/browse/LPP-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>> ]
>>
>> P T Withington updated LPP-5773:
>> --------------------------------
>>
>>             Status: Resolved  (was: In Review)
>>   Fixed in Change#: 8669
>>         Resolution: Fixed
>>           Assignee:     (was: P T Withington)
>>
>> r8669 | ptw | 2008-04-14 20:30:34 -0400 (Mon, 14 Apr 2008) | 42 lines
>> Changed paths:
>>  M /openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
>>  M /openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
>>  M /openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs
>>  M /openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapointer.lzs
>>  M /openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
>>  M /openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParsedPath.lzs
>>  M /openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
>>  M /openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs
>>  M /openlaszlo/trunk/WEB-INF/lps/schema/lfc.lzx
>>  M
>> /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
>> ClassModel.java
>>  M
>> /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
>> CompilerUtils.java
>>  M
>> /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
>> NodeModel.java
>>  A /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
>> Method.java
>>  M
>> /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
>> ScriptClass.java
>>  M
>> /openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
>> ScriptCompiler.java
>>  M /openlaszlo/trunk/test/smoke/regression.lzl
>>
>> Change 20080402-ptw-I by ptw at dueling-banjos.local on 2008-04-02  
>> 15:21:17
>> EDT
>>   in /Users/ptw/OpenLaszlo/ringding/
>>   for http://svn.openlaszlo.org/openlaszlo/trunk/
>>
>> Summary: Implement node id binders
>>
>> Bugs Fixed:
>> LPP-5773 'id's do not work in swf9'
>>
>> Technical Reviewer: hqm (pending)
>> QA Reviewer: dda (Message-Id: <
>> F6B87886-181C-4C8A-A4A1-87A251848CFF at ddanderson.com>)
>>
>> Details:
>>   Gobal names need to be bound using closures.
>>
>>   regression.lzl: Update test to work in swf9
>>
>>   schema/lfc.lzx: Add $lzc$bind_* attributes
>>
>>   LzNode, LzReplicationManager: Process binding of id's and global
>>   names early on.  Remove id setter (you are not allowed to change
>>   your id dynamically!)  Update destroy to work with id/global name
>>   binders.
>>
>>   LzCommand: add missing super call
>>
>>   LzAnimatorGroup, LzDatapointer: Make toString, _dbg_name safe
>>
>>   LzParsedPath: improve debug warnings
>>
>>   LzDataset: No longer define datasets globally
>>
>>   LzDatapath: You can't smash a method
>>
>>   Method, ScriptCompiler, ScriptClass, NodeModel, ClassModel,
>>   CompilerUtils: Distinguish between methods and function-valued
>>   vars.
>>
>> Tests:
>>   Henry's global test no longer complains, ant lztest, ant runlzunit
>>
>>
>>
>>> id's do not work in swf9
>>> ------------------------
>>>
>>>                Key: LPP-5773
>>>                URL: http://www.openlaszlo.org/jira/browse/LPP-5773
>>>            Project: OpenLaszlo
>>>         Issue Type: Bug
>>>         Components: Compiler - JavaScript
>>>   Affects Versions: Yodel, RingDing
>>>           Reporter: P T Withington
>>>           Priority: P0
>>>            Fix For: Yodel
>>>
>>>
>>> This test case fails in swf9
>>> <canvas width="800" height="600" debug="false">
>>>  <script when="immediate">
>>>  </script>
>>>  <view y="60" name="bar" bgcolor='${(trace("bgcolor"),0xff)}'
>> width="10" height="10" />
>>>  <text text='${(trace("bar: %s", bar),bar.y)}' id="foo" />
>>> </canvas>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the  
>> administrators:
>> http://www.openlaszlo.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com