[Laszlo-dev] For Review: Change 20080403-bargull-0 Summary: change LzDataset default-name to new regime

P T Withington ptw at laszlosystems.com
Fri Apr 4 12:03:52 PDT 2008


Sounds good

On 2008-04-03, at 15:07 EDT, André Bargull wrote:
> "operatorArgs" can be either 'null' or '0' and there is the  
> following test in "LzDatapointer#__LZprocessOperator(..)":
>> if ( pp.operatorArgs != null ){
>>    return p[ pp.operator ] ( pp.operatorArgs );
>> }
> But if AS3 does not support "nullable Number", I'll just comment  
> that type-info out resp. change it to "var operatorArgs:*" .
>
>
> P T Withington wrote:
>> Yeah, probably just not (yet) supported in AS3.  But do you really  
>> want a nullable number?  Is there not a better default, like maybe 0?
>>
>> On 2008-04-03, at 14:29 EDT, André Bargull wrote:
>>> I thought you could have nullable Numbers if you prepend '?' to  
>>> the type, at least I found that somewhere in the ES4 papers. And  
>>> our compiler does accept that syntax.
>>> So, it's just not allowed in AS3?
>>>
>>> - André
>>>
>>>
>>> On 4/3/2008 8:12 PM, Philip Romanik wrote:
>>>> Hi André,
>>>>
>>>> Approved, but you need to make one change in LzParsedPath:
>>>>
>>>>       var operatorArgs:Number? = null;
>>>>
>>>> This should be:
>>>>
>>>>       var operatorArgs = null;
>>>>
>>>> A number can't be null, and operatorArgs can be null.
>>>>
>>>>
>>>> Also, there is no Jira bug for this changeset. There must be a  
>>>> Jira bug to file against.
>>>>
>>>> Thanks!
>>>>
>>>> Phil
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>> Change 20080403-bargull-0 by bargull at dell--p4--2-53 on  
>>>>> 2008-04-03 17:49:17 in /home/Admin/src/svn/openlaszlo/trunk
>>>>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>>>> Summary: change LzDataset default-name to new regime
>>>>> New Features:
>>>>> Bugs Fixed:
>>>>> Technical Reviewer: promanik
>>>>> QA Reviewer: ptw
>>>>> Doc Reviewer: (pending)
>>>>> Documentation:
>>>>> Release Notes:
>>>>> Details:
>>>>> - change default-name for LzDataset to new regime
>>>>> - update AnonDatasetGenerator to use new regime
>>>>> - add more type-information to LzParsedPath
>>>>> Tests:
>>>>> alldata.lzx still works
>>>>> Files:
>>>>> M WEB-INF/lps/lfc/data/LzParsedPath.lzs
>>>>> M WEB-INF/lps/lfc/data/LzDataset.lzs
>>>>> Changeset:
>>>>> http://svn.openlaszlo.org/openlaszlo/patches/20080403- 
>>>>> bargull-0.tar
>>>>>
>>
>>




More information about the Laszlo-dev mailing list