[Laszlo-dev] For Review: Change 20080401-ptw-A Summary: Compile instances with methods as classes

[Henry Minsky]

I've got a fix for that, there is a little skew between the LzCanvas
implementation of initDone, because therea separate LzCanvas.js version for
swf9.

On Tue, Apr 1, 2008 at 7:04 PM, Donald Anderson <dda at ddanderson.com> wrote:

> Approved -- although I think we took a step back somewhere,
> perhaps that's already known.
>
> With this change, I'm seeing the swf9/hello.lzx compiling but
> not displaying anything.  Without this change (on updated tree),
> I see it not compiling at all:
>
> Users/clients/laszlo/lib/jakarta-tomcat-5.0.30/temp/lzswf9/lzgen14393/LzApplication.as(92):
> col: 8 Error: Access of possibly undefined property mystate through a
> reference with static type flash.display:DisplayObjectContainer.
>
> parent.mystate.remove()
>
> So the change fixed compilation errors at least.
>
>
> On Apr 1, 2008, at 4:25 PM, P T Withington wrote:
>
>  Change 20080401-ptw-A by ptw at dueling-banjos.local on 2008-04-01 16:15:19
> > EDT
> >   in /Users/ptw/OpenLaszlo/ringding-clean
> >   for http://svn.openlaszlo.org/openlaszlo/trunk
> >
> > Summary: Compile instances with methods as classes
> >
> > Bugs Fixed:
> > LPP-5625 'Implement instances with methods as singleton classes'
> >
> > Technical Reviewer: hqm (pending)
> > QA Reviewer: dda (pending)
> >
> > Details:
> >   LzNode, NodeModel: Move $classrootdepth computation to compile-time.
> >
> >   LzNode, LaszloCanvas, LzReplicationManager: Take care that
> >   _instanceAttrs may be null
> >
> >   LzRuntime: Don't clobber global in swf9
> >
> >   ClassCompiler, ClassModel: Move emitClassDeclaration to ClassModel
> >
> >   NodeModel: Leave id as an attribute, declare named children as
> >   attributes so they can be resolved.  Predicate for nodes that have
> >   methods.  Compile nodes with methods as singleton classes.
> >
> >   basecomponent:  Make the optional argument optional
> >
> > Tests:
> >   smokecheck, lztest, Henry's checkbox test compiles
> >
> > Files:
> > M      WEB-INF/lps/lfc/core/LzNode.lzs
> > M      WEB-INF/lps/lfc/views/LaszloCanvas.lzs
> > M      WEB-INF/lps/lfc/data/LzReplicationManager.lzs
> > M      WEB-INF/lps/lfc/compiler/LzRuntime.lzs
> > M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java
> > M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> > M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java
> > M      lps/components/base/basecomponent.lzx
> >
> > Changeset:
> > http://svn.openlaszlo.org/openlaszlo/patches/20080401-ptw-A.tar
> >
>
>
> --
>
> Don Anderson
> Java/C/C++, Berkeley DB, systems consultant
>
> voice: 617-547-7881
> email: dda at ddanderson.com
> www: http://www.ddanderson.com
>
>
>
>
>


-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20080401/4345e21d/attachment.html