[Laszlo-dev] For Review: Change 20070927-dda-D Summary: svn-commit should not call exit, it will logout the caller.

[Donald Anderson]

Hey folks, do an svn update on your tools,
and re-source svn-bash for this fix.

This bit me a couple times since I keep several
shell windows around - running svn-commit
in the 'wrong' window logged out the window.

- Don

On Sep 27, 2007, at 7:45 PM, P T Withington wrote:

> Approved.  Thanks!
>
> (Once you check in, you should send mail to laszlo-dev telling  
> people to update their tools and re-source the svn-bash file...)
>
> On 2007-09-27, at 19:41 EDT, Donald Anderson wrote:
>
>> Change 20070927-dda-D by dda at freddie.local on 2007-09-27 19:34:19 EDT
>>     in /Users/dda/laszlo/src/svn/tools/trunk
>>     for http://svn.openlaszlo.org/tools/trunk
>>
>> Summary: svn-commit should not call exit, it will logout the caller.
>>
>> New Features:
>>
>> Bugs Fixed: OBI-58
>>
>> Technical Reviewer: ptw
>> QA Reviewer: (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>>     On certain errors, svn-commit called 'exit'.  But svn-commit
>>     is a shell function that runs in the user's logon shell, not
>>     a subshell.  The proper action is to call return.
>>
>> Tests:
>>     create a fresh shell process (xterm or Terminal for Mac-OSX).
>>     run 'svn-commit'.  With the fix, the terminal does not close.
>>
>> Files:
>> M      svn/svn-bash.sh
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070927- 
>> dda-D.tar
>>
>>
>>
>> --
>>
>> Don Anderson
>> Java/C/C++, Berkeley DB, systems consultant
>>
>> Voice:  617-547-7881
>> Email:  dda at ddanderson.com
>> WWW:    http://www.ddanderson.com
>>
>


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

Voice:  617-547-7881
Email:  dda at ddanderson.com
WWW:    http://www.ddanderson.com