[Laszlo-dev] For Review: Change 20070925-maxcarlson-g Summary: Fix stretches
André Bargull
a.bargull at intensis.de
Wed Sep 26 15:15:54 PDT 2007
Not approved.
I would prefer to have these members of LzView in the class-definition,
i.e. for documentation etc.
So you may want to use "!==" instead of "!=", like:
[code]
function setWidth ( v ){
if (this._width !== v) {
...
}
}
[/code]
Max Carlson wrote:
> Change 20070925-maxcarlson-g by maxcarlson at plastik on 2007-09-25
> 15:42:07 PDT
> in /Users/maxcarlson/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix stretches
>
> New Features:
>
> Bugs Fixed: LPP-4778 - "LzView#setX(..)" and "LzView#setY(..)"
> optimization breaks xoffset / yoffset
>
> Technical Reviewer: promanik
> QA Reviewer: andrebargull at aol.com
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: Shouldn't have set defaults for _x/y/width/height.
>
>
> Tests:
> http://localhost:8080/trunk/examples/components/style_example.lzx runs
> correctly
>
> Files:
> M WEB-INF/lps/lfc/views/LaszloView.lzs
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20070925-maxcarlson-g.tar
>
--
Official OpenLaszlo-Committer ^_^
More information about the Laszlo-dev
mailing list