[Laszlo-dev] For Review: Change 20070925-maxcarlson-7, Summary: Fix xoffset and yoffset

[André Bargull]

Not approved.

You should explicitly check for a boolean value for the new parameter 
"force" in "LzView#setX(..)" resp. "LzView#setY(..)".
Reason: These methods are also called from "LzNode#__LZapplyArgs(..)"!

Testcase:
[code]
  <class name="testview" extends="view" >
    <method name="setY" >
      Debug.write("setY-caller: %w", arguments.caller.name);
      Debug.write("setY-arguments: %w", arguments);
      super.setY.apply(this, arguments);
    </method>
  </class>
 
  <testview y="0" />
  <testview y="10" />
[/code]

> Change 20070925-maxcarlson-7 by maxcarlson at plastik on 2007-09-25  
> 13:55:11 PDT
>      in /Users/maxcarlson/openlaszlo/trunk
>      for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix xoffset and yoffset
>
> New Features:
>
> Bugs Fixed: LPP-4778 - "LzView#setX(..)" and "LzView#setY(..)"  
> optimization breaks xoffset / yoffset
>
> Technical Reviewer: promanik
> QA Reviewer: bargull
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: lztest-view.lzx - add test for x/yoffset and one with rotation.
>
> LaszloView.lzs - Add correct initial values for _x, _y, _width,  
> _height.  Add argument to setX/setY() to override cached values.   
> setRotation/setXOffset/setYOffset() call setX/setY() with force set  
> to true.
>
>
> Tests: Run updated lztest-view.lzx with and without the changes to  
> LaszloView.lzs.  You should see the test fail without the LaszloView  
> changes.  Tested in swf7/8/dhtml.
>
> Files:
> M      test/lztest/lztest-view.lzx
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070925- 
> maxcarlson-7.tar

-- 

Official OpenLaszlo-Committer ^_^