[Laszlo-dev] For Review: Change 20070925-ptw-2 Summary: Fix SWF constraint lossage in r6548

[Donald Anderson]

Approved!

On Sep 25, 2007, at 12:20 PM, P T Withington wrote:

> Change 20070925-ptw-2 by ptw at dueling-banjos.local on 2007-09-25  
> 11:56:09 EDT
>     in /Users/ptw/OpenLaszlo/ringding-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix SWF constraint lossage in r6548
>
> Bugs Fixed:
> LPP-4786 'Script compiler needs refactoring before SWF9 work can  
> begin'
>
> Technical Reviewer: dda at ddanderson.com (pending)
> QA Reviewer: hminsky (pending)
> Doc Reviewer: (pending)
>
> Details:
>     The remodularization tripped up the SWF Generator because it was
>     analyzing the constraint body _after_ it had been optimized to
>     inline the setAttribute call.  Move the dependency analyzer to the
>     top of translateFunctionInternal, as is done in Javascript
>     Generator.
>
> Tests:
>     Enabling ReferenceGenerator.debugConstraints shows that
>     constraints are actually being processed.  smokecheck.lzx passes
>     in SWF now, and the SWF debugger window shows up again.
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070925- 
> ptw-2.tar


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

Voice:  617-547-7881
Email:  dda at ddanderson.com
WWW:    http://www.ddanderson.com