[Laszlo-dev] For Review: Change 20070915-maxcarlson-Q Summary: Re-apply dhtml inputtext height fixes to legals

[Max Carlson]

Change 20070915-maxcarlson-Q by maxcarlson at plastik on 2007-09-15  
12:02:57 PDT
     in /Users/maxcarlson/openlaszlo/legals
     for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Re-apply dhtml inputtext height fixes to legals

New Features:

Bugs Fixed: LPP-4658 - DHTML inputtext is the incorrect height

Technical Reviewer: promanik
QA Reviewer: hminsky
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: This change is _almost_ identical to that checked into r6464  
- except now LzTextSprite.js uses the Lz.__setAttr() API to work with  
the setAttribute() inlining changes.   You could almost eyeball it.   
 From the previous change:

LzSprite.js - Add text_measurement_use_insertadjacenthtml quirk and  
turn it on for IE.  Clean up testing to prevent LzModeManager and  
LzKeyboardKernel exceptions when applications are loaded or unloaded  
and the keyboard and mouse are active.

LzTextSprite.js - getTextSize() now does all text measurement inside  
a div, rather than attaching to the body and uses the   
text_measurement_use_insertadjacenthtml quirk.

LzInputTextSprite.js - Add getTextHeight() implementation to ensure  
correct heights are reported.

Tests: http://localhost:8080/legals/test/lztest/lztest-textheight.lzx? 
lzr=dhtml&debug=true runs as before, and tabbing into and out of the  
inputtext in http://localhost:8080/legals/examples/components/ 
style_example.lzx?lzt=html&lzr=dhtml no longer causes it to resize.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070915- 
maxcarlson-Q.tar