[Laszlo-dev] For Review: Change 20070915-maxcarlson-8 Summary: Fix Flash player installation and upgrading behavior

[Max Carlson]

Change 20070915-maxcarlson-8 by maxcarlson at plastik on 2007-09-15  
10:35:13 PDT
     in /Users/maxcarlson/openlaszlo/wafflecone
     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: Fix Flash player installation and upgrading behavior

New Features:

Bugs Fixed: LPP-4736 - Iframe used for history mechanism in IE is  
visible, LPP-4737 - Empty graphic seen when you navigate to the OL  
app without Flash, LPP-4734 - Flash installation - after flash player  
has installed the app doesn't load

Technical Reviewer: pkang
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: ExpressInstall.as - Reload on app completion, use correct  
scope for other callbacks.

lzhistory.js - Set style of iframe correctly.  Skip _checklocationhash 
() when we're installing or upgrading the Flash player.

embed-library.lzs - Move flash.js include after embednew.js so  
browser detection is available.

flash.js - Use Lz.__BrowserDetect instead of homecooked browser  
detection.  Reload the page when done installing a player for the  
first time.  Fix ExpressInstall behavior in write().  Upgrade with  
expressinstall if the player version is less than the required Flash  
version.  Always run installers in swf8 so loaded() callbacks are  
reliable.  Use static URL rather than respecting the current http  
protocol.


Tests: Uninstall the flash player in windows.  http://localhost:8080/ 
wafflecone/test/history/history.lzx?lzr=swf8 will install the player  
and run the application correctly.  After uninstalling, and  
installing player 7.0.19, http://localhost:8080/wafflecone/test/ 
history/history.lzx?lzr=swf8 upgrades correctly via expressinstall.   
IE history iframes are no longer visible.

Files:
M      WEB-INF/lps/lfc/kernel/swf/dojo/flash8/ExpressInstall.as
M      lps/includes/source/lzhistory.js
M      lps/includes/source/embed-library.lzs
M      lps/includes/source/flash.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070915- 
maxcarlson-8.tar